NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit71b121f

committed

Fix pg_dump's sigTermHandler() to use _exit() not exit().

sigTermHandler() tried to be careful to invoke only operations thatare safe to do in a signal handler. But for some reason we forgotthat exit(3) is not among those, because it calls atexit handlersthat might do various random things. (pg_dump itself installs noatexit handlers, but e.g. OpenSSL does.) That led to crashes orlockups when attempting to terminate a parallel dump or restorevia a signal.Fix by calling _exit() instead.Per bug #16199 from Raúl Marín. Back-patch to all supported branches.Discussion:https://postgr.es/m/16199-cb2f121146a96f9b@postgresql.org

1 parentfd436bb commit71b121fCopy full SHA for 71b121f

File tree

1 file changed

-2

lines changed

src/bin/pg_dump
- parallel.c

1 file changed

-2

lines changed

`‎src/bin/pg_dump/parallel.c`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -607,8 +607,11 @@ sigTermHandler(SIGNAL_ARGS)`
`607`	`607`	`write_stderr("terminated by user\n");`
`608`	`608`	`}`
`609`	`609`
`610`		`-/* And die. */`
`611`		`-exit(1);`
	`610`	`+/*`
	`611`	`+ * And die, using _exit() not exit() because the latter will invoke atexit`
	`612`	`+ * handlers that can fail if we interrupted related code.`
	`613`	`+ */`
	`614`	`+_exit(1);`
`612`	`615`	`}`
`613`	`616`
`614`	`617`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit71b121f

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/parallel.c`

0 commit comments