forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit7107d58
committed
Fix misplacement of submake-generated-headers prerequisites.
The sequence "configure; cd src/pl/plpython; make -j" failed due totrying to compile plpython's .o files before the generated headersfinished building. (This is an important real-world case, since it'sthe typical second step when building both plpython2 and plpython3.)This happens because the submake-generated-headers target is notplaced in a way to make it a prerequisite to compiling the .o files.Fix that.Checking other uses of submake-generated-headers, I noted that the oneattached to pg_regress was similarly misplaced; but it's actually notneeded at all for pg_regress.o, rather regress.o, so move it to be aprerequisite of that.Back-patch to 9.6 where submake-generated-headers was introduced(by commit548af97). It's not immediately clear to me why theprevious coding didn't have the same issue; but since we've nothad field reports of plpython make failing, leave it alone in theolder branches.Pavel Raiskup and Tom LaneDiscussion: <1925924.izSMJEZO3x@unused-4-107.brq.redhat.com>1 parenta432729 commit7107d58
2 files changed
+6
-2
lines changedLines changed: 3 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
95 | 95 |
| |
96 | 96 |
| |
97 | 97 |
| |
98 |
| - | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
99 | 101 |
| |
100 | 102 |
| |
101 | 103 |
| |
|
Lines changed: 3 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
36 | 36 |
| |
37 | 37 |
| |
38 | 38 |
| |
39 |
| - | |
| 39 | + | |
40 | 40 |
| |
41 | 41 |
| |
42 | 42 |
| |
| |||
65 | 65 |
| |
66 | 66 |
| |
67 | 67 |
| |
| 68 | + | |
| 69 | + | |
68 | 70 |
| |
69 | 71 |
| |
70 | 72 |
| |
|
0 commit comments
Comments
(0)