NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit70b9adb

committed

Ensure we have a snapshot when updating pg_index in index_drop().

I assumed that all index_drop() callers set an active snapshotbeforehand, but that is evidently not true. One counterexample isautovacuum, which doesn't set an active snapshot when cleaning uporphan temp indexes. To fix, unconditionally push an activesnapshot before updating pg_index in index_drop().Oversight in commitb52adba.Reported-by: Masahiko SawadaReviewed-by: Stepan Neretin, Masahiko SawadaDiscussion:https://postgr.es/m/CAD21AoBgF9etQrXbN9or_YHsmBRJHHNUEkhHp9rGK9CyQv5aTQ%40mail.gmail.com

1 parent11b7de4 commit70b9adbCopy full SHA for 70b9adb

File tree

1 file changed

-8

lines changed

src/backend/catalog
- index.c

1 file changed

-8

lines changed

`‎src/backend/catalog/index.c`

Lines changed: 3 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -2336,13 +2336,9 @@ index_drop(Oid indexId, bool concurrent, bool concurrent_lock_mode)`
`2336`	`2336`
`2337`	`2337`	`/*`
`2338`	`2338`	`* Updating pg_index might involve TOAST table access, so ensure we have a`
`2339`		`- * valid snapshot. We only expect to get here without a snapshot in the`
`2340`		`- * concurrent path.`
	`2339`	`+ * valid snapshot.`
`2341`	`2340`	`*/`
`2342`		`-if (concurrent)`
`2343`		`-PushActiveSnapshot(GetTransactionSnapshot());`
`2344`		`-else`
`2345`		`-Assert(HaveRegisteredOrActiveSnapshot());`
	`2341`	`+PushActiveSnapshot(GetTransactionSnapshot());`
`2346`	`2342`
`2347`	`2343`	`/*`
`2348`	`2344`	`* fix INDEX relation, and check for expressional index`
`@@ -2361,8 +2357,7 @@ index_drop(Oid indexId, bool concurrent, bool concurrent_lock_mode)`
`2361`	`2357`	`ReleaseSysCache(tuple);`
`2362`	`2358`	`table_close(indexRelation,RowExclusiveLock);`
`2363`	`2359`
`2364`		`-if (concurrent)`
`2365`		`-PopActiveSnapshot();`
	`2360`	`+PopActiveSnapshot();`
`2366`	`2361`
`2367`	`2362`	`/*`
`2368`	`2363`	`* if it has any expression columns, we might have stored statistics about`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit70b9adb

File tree

1 file changed

1 file changed

`‎src/backend/catalog/index.c`

0 commit comments