NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit70a7732

committed

Remove support for upgrading extensions from "unpackaged" state.

Andres Freund pointed out that allowing non-superusers to run"CREATE EXTENSION ... FROM unpackaged" has security risks, sincethe unpackaged-to-1.0 scripts don't try to verify that the existingobjects they're modifying are what they expect. Just attaching suchobjects to an extension doesn't seem too dangerous, but some of themdo more than that.We could have resolved this, perhaps, by still requiring superuserprivilege to use the FROM option. However, it's fair to ask just whatwe're accomplishing by continuing to lug the unpackaged-to-1.0 scriptsforward. None of them have received any real testing since 9.1 days,so they may not even work anymore (even assuming that one could stillload the previous "loose" object definitions into a v13 database).And an installation that's trying to go from pre-9.1 to v13 or laterin one jump is going to have worse compatibility problems than whetherthere's a trivial way to convert their contrib modules into extensionstyle.Hence, let's just drop both those scripts and the core-code supportfor "CREATE EXTENSION ... FROM".Discussion:https://postgr.es/m/20200213233015.r6rnubcvl4egdh5r@alap3.anarazel.de

1 parent2f9c46a commit70a7732Copy full SHA for 70a7732

File tree

84 files changed

+55

-2428

lines changed

contrib
- btree_gin
  - Makefile
  - btree_gin--unpackaged--1.0.sql
- btree_gist
  - Makefile
  - btree_gist--unpackaged--1.0.sql
- citext
  - Makefile
  - citext--unpackaged--1.0.sql
- cube
  - Makefile
  - cube--unpackaged--1.0.sql
- dblink
  - Makefile
  - dblink--unpackaged--1.0.sql
- dict_int
  - Makefile
  - dict_int--unpackaged--1.0.sql
- dict_xsyn
  - Makefile
  - dict_xsyn--unpackaged--1.0.sql
- earthdistance
  - Makefile
  - earthdistance--unpackaged--1.0.sql
- fuzzystrmatch
  - Makefile
  - fuzzystrmatch--unpackaged--1.0.sql
- hstore
  - Makefile
  - hstore--unpackaged--1.0.sql
- intagg
  - Makefile
  - intagg--unpackaged--1.0.sql
- intarray
  - Makefile
  - intarray--unpackaged--1.0.sql
- isn
  - Makefile
  - isn--unpackaged--1.0.sql
- lo
  - Makefile
  - lo--unpackaged--1.0.sql
- ltree
  - Makefile
  - ltree--unpackaged--1.0.sql
- pageinspect
  - Makefile
  - pageinspect--unpackaged--1.0.sql
- pg_buffercache
  - Makefile
  - pg_buffercache--unpackaged--1.0.sql
- pg_freespacemap
  - Makefile
  - pg_freespacemap--unpackaged--1.0.sql
- pg_stat_statements
  - Makefile
  - pg_stat_statements--unpackaged--1.0.sql
- pg_trgm
  - Makefile
  - pg_trgm--1.3.sql
  - pg_trgm--unpackaged--1.0.sql
- pgcrypto
  - Makefile
  - pgcrypto--unpackaged--1.0.sql
- pgrowlocks
  - Makefile
  - pgrowlocks--unpackaged--1.0.sql
- pgstattuple
  - Makefile
  - pgstattuple--unpackaged--1.0.sql
- seg
  - Makefile
  - seg--unpackaged--1.0.sql
- spi
  - Makefile
  - autoinc--unpackaged--1.0.sql
  - insert_username--unpackaged--1.0.sql
  - moddatetime--unpackaged--1.0.sql
  - refint--unpackaged--1.0.sql
- sslinfo
  - Makefile
  - sslinfo--unpackaged--1.0.sql
- tablefunc
  - Makefile
  - tablefunc--unpackaged--1.0.sql
- unaccent
  - Makefile
  - unaccent--unpackaged--1.0.sql
- uuid-ossp
  - Makefile
  - uuid-ossp--unpackaged--1.0.sql
- xml2
  - Makefile
  - xml2--unpackaged--1.0.sql
  - xml2.control
doc/src/sgml
src
- backend
  - commands
    - extension.c
  - parser
    - gram.y
- pl
- test/modules/test_parser
  - Makefile
  - test_parser--unpackaged--1.0.sql

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

84 files changed

+55

-2428

lines changed

`‎contrib/btree_gin/Makefile`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ OBJS = \`
`7`	`7`
`8`	`8`	`EXTENSION = btree_gin`
`9`	`9`	`DATA = btree_gin--1.0.sql btree_gin--1.0--1.1.sql btree_gin--1.1--1.2.sql\`
`10`		`- btree_gin--1.2--1.3.sql btree_gin--unpackaged--1.0.sql`
	`10`	`+ btree_gin--1.2--1.3.sql`
`11`	`11`	`PGFILEDESC = "btree_gin - B-tree equivalent GIN operator classes"`
`12`	`12`
`13`	`13`	`REGRESS = install_btree_gin int2 int4 int8 float4 float8 money oid\`

`‎contrib/btree_gin/btree_gin--unpackaged--1.0.sql`

Lines changed: 0 additions & 119 deletions

This file was deleted.

`‎contrib/btree_gist/Makefile`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ OBJS = \`
`29`	`29`	`btree_uuid.o`
`30`	`30`
`31`	`31`	`EXTENSION = btree_gist`
`32`		`-DATA = btree_gist--unpackaged--1.0.sql btree_gist--1.0--1.1.sql\`
	`32`	`+DATA = btree_gist--1.0--1.1.sql\`
`33`	`33`	`btree_gist--1.1--1.2.sql btree_gist--1.2.sql btree_gist--1.2--1.3.sql\`
`34`	`34`	`btree_gist--1.3--1.4.sql btree_gist--1.4--1.5.sql`
`35`	`35`	`PGFILEDESC = "btree_gist - B-tree equivalent GiST operator classes"`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit70a7732

File tree

84 files changed

Some content is hidden

84 files changed

`‎contrib/btree_gin/Makefile`

`‎contrib/btree_gin/btree_gin--unpackaged--1.0.sql`

`‎contrib/btree_gist/Makefile`

0 commit comments