Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit709e461

Browse files
committed
Fix EXPLAIN so that it doesn't emit invalid XML in corner cases.
With track_io_timing = on, EXPLAIN (ANALYZE, BUFFERS) will emit fieldsnamed like "I/O Read Time". The slash makes that invalid as an XMLelement name, so that adding FORMAT XML would produce invalid XML.We already have code in there to translate spaces to dashes, so let'sgeneralize that to convert anything that isn't a valid XML name character,viz letters, digits, hyphens, underscores, and periods. We could justreject slashes, which would run a bit faster. But the fact that this wentunnoticed for so long doesn't give me a warm feeling that we'd notice thenext creative violation, so let's make it a permanent fix.Reported by Markus Winand, though this isn't his initial patch proposal.Back-patch to 9.2 where track_io_timing was added. The problem is onlylatent in 9.1, so I don't feel a need to fix it there.Discussion: <E0BF6A45-68E8-45E6-918F-741FB332C6BB@winand.at>
1 parent5e21b68 commit709e461

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

‎src/backend/commands/explain.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3312,21 +3312,23 @@ ExplainSeparatePlans(ExplainState *es)
33123312
* Optionally, OR in X_NOWHITESPACE to suppress the whitespace we'd normally
33133313
* add.
33143314
*
3315-
* XML tag names can't contain white space, so we replace any spaces in
3316-
* "tagname" with dashes.
3315+
* XML restricts tag names more than our other output formats, eg they can't
3316+
* contain white space or slashes. Replace invalid characters with dashes,
3317+
* so that for example "I/O Read Time" becomes "I-O-Read-Time".
33173318
*/
33183319
staticvoid
33193320
ExplainXMLTag(constchar*tagname,intflags,ExplainState*es)
33203321
{
33213322
constchar*s;
3323+
constchar*valid="ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789-_.";
33223324

33233325
if ((flags&X_NOWHITESPACE)==0)
33243326
appendStringInfoSpaces(es->str,2*es->indent);
33253327
appendStringInfoCharMacro(es->str,'<');
33263328
if ((flags&X_CLOSING)!=0)
33273329
appendStringInfoCharMacro(es->str,'/');
33283330
for (s=tagname;*s;s++)
3329-
appendStringInfoCharMacro(es->str,(*s==' ') ?'-' :*s);
3331+
appendStringInfoChar(es->str,strchr(valid,*s) ?*s :'-');
33303332
if ((flags&X_CLOSE_IMMEDIATE)!=0)
33313333
appendStringInfoString(es->str," /");
33323334
appendStringInfoCharMacro(es->str,'>');

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp