NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit7095003

committed

Make deadlock_timeout PGC_SUSET rather than PGC_SIGHUP.

This allows deadlock_timeout to be reduced for transactions that areparticularly likely to be involved in a deadlock, thus detecting itmore quickly. It is also potentially useful as a poor-man's deadlockpriority mechanism: a transaction with a high deadlock_timeout is lesslikely to be chosen as the victim than one with a lowdeadlock_timeout. Since that could be used to game the system, wemake this PGC_SUSET rather than PGC_USERSET.At some point, it might be worth thinking about a more explicitpriority mechanism, since using this is far from fool-proof. Butlet's see whether there's enough use case to justify the additionalwork before we go down that route.Noah Misch, reviewed by Shigeru Hanada

1 parent8f9fe6e commit7095003Copy full SHA for 7095003

File tree

2 files changed

-3

lines changed

doc/src/sgml
- config.sgml
src/backend/utils/misc
- guc.c

2 files changed

-3

lines changed

`‎doc/src/sgml/config.sgml`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -5266,7 +5266,8 @@ dynamic_library_path = 'C:\tools\postgresql;H:\my_project\lib;$libdir'`
`5266`	`5266`	`practice. On a heavily loaded server you might want to raise it.`
`5267`	`5267`	`Ideally the setting should exceed your typical transaction time,`
`5268`	`5268`	`so as to improve the odds that a lock will be released before`
`5269`		`- the waiter decides to check for deadlock.`
	`5269`	`+ the waiter decides to check for deadlock. Only superusers can change`
	`5270`	`+ this setting.`
`5270`	`5271`	`</para>`
`5271`	`5272`
`5272`	`5273`	`<para>`

`‎src/backend/utils/misc/guc.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1532,8 +1532,8 @@ static struct config_int ConfigureNamesInt[] =`
`1532`	`1532`	`},`
`1533`	`1533`
`1534`	`1534`	`{`
`1535`		`-/* This isPGC_SIGHUP so all backends have the same value. */`
`1536`		`-{"deadlock_timeout",PGC_SIGHUP,LOCK_MANAGEMENT,`
	`1535`	`+/* This isPGC_SUSET to prevent hiding from log_lock_waits. */`
	`1536`	`+{"deadlock_timeout",PGC_SUSET,LOCK_MANAGEMENT,`
`1537`	`1537`	`gettext_noop("Sets the time to wait on a lock before checking for deadlock."),`
`1538`	`1538`	`NULL,`
`1539`	`1539`	`GUC_UNIT_MS`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7095003

File tree

2 files changed

2 files changed

`‎doc/src/sgml/config.sgml`

`‎src/backend/utils/misc/guc.c`

0 commit comments