NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit704e1db

committed

Remove some useless logs from the TAP tests of pgbench

002_pgbench_no_server was printing some array pointers instead of theactual contents of those arrays for the expected outputs of stdout andstderr for a tested command. This does not add any new information thatcan help with debugging as the test names allow to track failurelocations, if any.This commit simply removes those logs as the rest of the printedinformation is redundant with command_checks_all().Per discussion with Andrew Dunstan and Álvaro Herrera.Discussion:https://postgr.es/m/YNXNFaG7IgkzZanD@paquier.xyzBackpatch-through: 11

1 parent5a0f1c8 commit704e1dbCopy full SHA for 704e1db

File tree

1 file changed

-1

lines changed

src/bin/pgbench/t
- 002_pgbench_no_server.pl

1 file changed

-1

lines changed

`‎src/bin/pgbench/t/002_pgbench_no_server.pl`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,6 @@ sub pgbench`
`26`	`26`	`local$Test::Builder::Level =$Test::Builder::Level + 1;`
`27`	`27`
`28`	`28`	`my ($opts,$stat,$out,$err,$name) =@_;`
`29`		`-printSTDERR"opts=$opts, stat=$stat, out=$out, err=$err, name=$name";`
`30`	`29`	`command_checks_all(['pgbench',split(/\s+/,$opts) ],`
`31`	`30`	`$stat,$out,$err,$name);`
`32`	`31`	`return;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit704e1db

File tree

1 file changed

1 file changed

`‎src/bin/pgbench/t/002_pgbench_no_server.pl`

0 commit comments