NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit701d918

committed

Fix misleading comments about background worker registration.

Since6bc8ef0, the maximum numberof backends can't change as background workers are registered, butthese comments still reflect the way things worked prior to that.Also, per recent discussion, some modules call SetConfigOption()from _PG_init(). It's not entirely clear to me whether we want toregard that as a fully supported operation, but since we know it'sa thing that happens, it at least deserves a mention in the comments,so add that.Nathan Bossart, reviewed by Anton A. MelnikovDiscussion:http://postgr.es/m/20220419154658.GA2487941@nathanxps13

1 parentee97d46 commit701d918Copy full SHA for 701d918

File tree

2 files changed

-9

lines changed

src/backend
- postmaster
  - postmaster.c
- utils/init
  - postinit.c

2 files changed

-9

lines changed

`‎src/backend/postmaster/postmaster.c`

Lines changed: 4 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -1005,10 +1005,8 @@ PostmasterMain(int argc, char *argv[])`
`1005`	`1005`	`LocalProcessControlFile(false);`
`1006`	`1006`
`1007`	`1007`	`/*`
`1008`		`- * Register the apply launcher. Since it registers a background worker,`
`1009`		`- * it needs to be called before InitializeMaxBackends(), and it's probably`
`1010`		`- * a good idea to call it before any modules had chance to take the`
`1011`		`- * background worker slots.`
	`1008`	`+ * Register the apply launcher. It's probably a good idea to call this`
	`1009`	`+ * before any modules had a chance to take the background worker slots.`
`1012`	`1010`	`*/`
`1013`	`1011`	`ApplyLauncherRegister();`
`1014`	`1012`
`@@ -1029,8 +1027,8 @@ PostmasterMain(int argc, char *argv[])`
`1029`	`1027`	`#endif`
`1030`	`1028`
`1031`	`1029`	`/*`
`1032`		`- * Now that loadable modules have had their chance toregister background`
`1033`		`- *workers,calculate MaxBackends.`
	`1030`	`+ * Now that loadable modules have had their chance toalter any GUCs,`
	`1031`	`+ * calculate MaxBackends.`
`1034`	`1032`	`*/`
`1035`	`1033`	`InitializeMaxBackends();`
`1036`	`1034`

`‎src/backend/utils/init/postinit.c`

Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -538,9 +538,8 @@ pg_split_opts(char *argv, int argcp, const char *optstr)`
`538`	`538`	`/*`
`539`	`539`	`* Initialize MaxBackends value from config options.`
`540`	`540`	`*`
`541`		`- * This must be called after modules have had the chance to register background`
`542`		`- * workers in shared_preload_libraries, and before shared memory size is`
`543`		`- * determined.`
	`541`	`+ * This must be called after modules have had the chance to alter GUCs in`
	`542`	`+ * shared_preload_libraries and before shared memory size is determined.`
`544`	`543`	`*`
`545`	`544`	`* Note that in EXEC_BACKEND environment, the value is passed down from`
`546`	`545`	`* postmaster to subprocesses via BackendParameters in SubPostmasterMain; only`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit701d918

File tree

2 files changed

2 files changed

`‎src/backend/postmaster/postmaster.c`

`‎src/backend/utils/init/postinit.c`

0 commit comments