NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit6ff2e8c

committed

Simplify version check for SKIP clause

Checking for the required versions of IO::Pty as well as IPC::Runcan be achieved with a single eval call, and by using the VERSIONfunction the comparison is guaranteed to follow the same rules ascalling 'use' on the module with a version.Reported-by: Andrew Dunstan <andrew@dunslane.net>Discussion:https://postgr.es/m/6d880ea2-f8ca-f458-4dcd-a7a3e6d6cd7c@dunslane.net

1 parent980e887 commit6ff2e8cCopy full SHA for 6ff2e8c

File tree

1 file changed

-1

lines changed

src/test/authentication/t
- 001_password.pl

1 file changed

-1

lines changed

`‎src/test/authentication/t/001_password.pl`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ sub test_conn`
`107`	`107`	`SKIP:`
`108`	`108`	`{`
`109`	`109`	`skip"IO::Pty and IPC::Run >= 0.98 required", 1unless`
`110`		`-(eval {require IO::Pty;} &&eval {$IPC::Run::VERSION >='0.98' });`
	`110`	`+eval {require IO::Pty; IPC::Run->VERSION('0.98'); };`
`111`	`111`
`112`	`112`	`# Alter the password on the created role using \password in psql to ensure`
`113`	`113`	`# that clientside password changes use the scram_iterations value when`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6ff2e8c

File tree

1 file changed

1 file changed

`‎src/test/authentication/t/001_password.pl`

0 commit comments