NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit6fd144e

committed

Fix integer underflow in shared memory debugging

dsa_dump would print a large negative number instead of zero forsegment bin 0. Fix by explicitly checking for underflow and addspecial case for bin 0. Backpatch to all supported versions.Author: Ian Ilyasov <ianilyasov@outlook.com>Reviewed-by: Robert Haas <robertmhaas@gmail.com>Discussion:https://postgr.es/m/GV1P251MB1004E0D09D117D3CECF9256ECD502@GV1P251MB1004.EURP251.PROD.OUTLOOK.COMBackpatch-through: v12

1 parentb3f6b14 commit6fd144eCopy full SHA for 6fd144e

File tree

1 file changed

-3

lines changed

src/backend/utils/mmgr
- dsa.c

1 file changed

-3

lines changed

`‎src/backend/utils/mmgr/dsa.c`

Lines changed: 7 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1113,9 +1113,13 @@ dsa_dump(dsa_area *area)`
`1113`	`1113`	`{`
`1114`	`1114`	`dsa_segment_indexsegment_index;`
`1115`	`1115`
`1116`		`-fprintf(stderr,`
`1117`		`-" segment bin %zu (at least %d contiguous pages free):\n",`
`1118`		`-i,1 << (i-1));`
	`1116`	`+if (i==0)`
	`1117`	`+fprintf(stderr,`
	`1118`	`+" segment bin %zu (no contiguous free pages):\n",i);`
	`1119`	`+else`
	`1120`	`+fprintf(stderr,`
	`1121`	`+" segment bin %zu (at least %d contiguous pages free):\n",`
	`1122`	`+i,1 << (i-1));`
`1119`	`1123`	`segment_index=area->control->segment_bins[i];`
`1120`	`1124`	`while (segment_index!=DSA_SEGMENT_INDEX_NONE)`
`1121`	`1125`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6fd144e

File tree

1 file changed

1 file changed

`‎src/backend/utils/mmgr/dsa.c`

0 commit comments