NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit6fa391b

committed

Avoid masking a function parameter name with a local variable name.

No actual bug here, but it might confuse readers, so change the nameof the local variable.Ashutosh Bapat

1 parentbd673e8 commit6fa391bCopy full SHA for 6fa391b

File tree

1 file changed

-8

lines changed

src/backend/optimizer/path
- joinpath.c

1 file changed

-8

lines changed

`‎src/backend/optimizer/path/joinpath.c`

Lines changed: 8 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,7 @@ add_paths_to_joinrel(PlannerInfo *root,`
`131`	`131`	`*/`
`132`	`132`	`foreach(lc,root->join_info_list)`
`133`	`133`	`{`
`134`		`-SpecialJoinInfosjinfo= (SpecialJoinInfo)lfirst(lc);`
	`134`	`+SpecialJoinInfosjinfo2= (SpecialJoinInfo)lfirst(lc);`
`135`	`135`
`136`	`136`	`/*`
`137`	`137`	`* SJ is relevant to this join if we have some part of its RHS`
`@@ -140,19 +140,19 @@ add_paths_to_joinrel(PlannerInfo *root,`
`140`	`140`	`* join has already been proven legal.) If the SJ is relevant, it`
`141`	`141`	`* presents constraints for joining to anything not in its RHS.`
`142`	`142`	`*/`
`143`		`-if (bms_overlap(joinrel->relids,sjinfo->min_righthand)&&`
`144`		`-!bms_overlap(joinrel->relids,sjinfo->min_lefthand))`
	`143`	`+if (bms_overlap(joinrel->relids,sjinfo2->min_righthand)&&`
	`144`	`+!bms_overlap(joinrel->relids,sjinfo2->min_lefthand))`
`145`	`145`	`extra.param_source_rels=bms_join(extra.param_source_rels,`
`146`	`146`	`bms_difference(root->all_baserels,`
`147`		`-sjinfo->min_righthand));`
	`147`	`+sjinfo2->min_righthand));`
`148`	`148`
`149`	`149`	`/* full joins constrain both sides symmetrically */`
`150`		`-if (sjinfo->jointype==JOIN_FULL&&`
`151`		`-bms_overlap(joinrel->relids,sjinfo->min_lefthand)&&`
`152`		`-!bms_overlap(joinrel->relids,sjinfo->min_righthand))`
	`150`	`+if (sjinfo2->jointype==JOIN_FULL&&`
	`151`	`+bms_overlap(joinrel->relids,sjinfo2->min_lefthand)&&`
	`152`	`+!bms_overlap(joinrel->relids,sjinfo2->min_righthand))`
`153`	`153`	`extra.param_source_rels=bms_join(extra.param_source_rels,`
`154`	`154`	`bms_difference(root->all_baserels,`
`155`		`-sjinfo->min_lefthand));`
	`155`	`+sjinfo2->min_lefthand));`
`156`	`156`	`}`
`157`	`157`
`158`	`158`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6fa391b

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/path/joinpath.c`

0 commit comments