Commit6f9a62b

committed

SQL/JSON: Remove useless code in ExecInitJsonExpr()

The code was for adding an unconditional JUMP to the next step,which is unnecessary processing.Reported-by: Jian He <jian.universality@gmail.com>Discussion:https://postgr.es/m/CACJufxEo4sUjKCYtda0_qt9tazqqKPmF1cqhW9KBOUeJFqQd2g@mail.gmail.comBackpatch-through: 17

1 parent4fc6a55 commit6f9a62bCopy full SHA for 6f9a62b

File tree

-15

lines changed

-15

lines changed

Lines changed: 0 additions & 15 deletions

Original file line number	Diff line number	Diff line change
`@@ -4312,21 +4312,6 @@ ExecInitJsonExpr(JsonExpr jsexpr, ExprState state,`
`4312`	`4312`	`scratch->d.constval.isnull= true;`
`4313`	`4313`	`ExprEvalPushStep(state,scratch);`
`4314`	`4314`
`4315`		`-/*`
`4316`		`- * Jump to coerce the NULL using json_populate_type() if needed. Coercing`
`4317`		`- * NULL is only interesting when the RETURNING type is a domain whose`
`4318`		`- * constraints must be checked. jsexpr->use_json_coercion must have been`
`4319`		`- * set in that case.`
`4320`		`- */`
`4321`		`-if (get_typtype(jsexpr->returning->typid)==TYPTYPE_DOMAIN&&`
`4322`		`-DomainHasConstraints(jsexpr->returning->typid))`
`4323`		`-{`
`4324`		`-Assert(jsexpr->use_json_coercion);`
`4325`		`-scratch->opcode=EEOP_JUMP;`
`4326`		`-scratch->d.jump.jumpdone=state->steps_len+1;`
`4327`		`-ExprEvalPushStep(state,scratch);`
`4328`		`-}`
`4329`		`-`
`4330`	`4315`	`/*`
`4331`	`4316`	`* To handle coercion errors softly, use the following ErrorSaveContext to`
`4332`	`4317`	`* pass to ExecInitExprRec() when initializing the coercion expressions`

Comments

(0)