NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit6f3823b

committed

Fix --dry-run mode of pg_rewind

Even if --dry-run mode was specified, the control file was gettingupdated, preventing follow-up runs of pg_rewind to work properly on thetarget data folder. The origin of the problem came from the refactoringdone byce6afc6.Author: Alexey KondratovDiscussion:https://postgr.es/m/7ca88204-3e0b-2f4c-c8af-acadc4b266e5@postgrespro.ruBackpatch-through: 12

1 parent8e10405 commit6f3823bCopy full SHA for 6f3823b

File tree

1 file changed

-1

lines changed

src/bin/pg_rewind
- pg_rewind.c

1 file changed

-1

lines changed

`‎src/bin/pg_rewind/pg_rewind.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -435,7 +435,8 @@ main(int argc, char **argv)`
`435`	`435`	`ControlFile_new.minRecoveryPoint=endrec;`
`436`	`436`	`ControlFile_new.minRecoveryPointTLI=endtli;`
`437`	`437`	`ControlFile_new.state=DB_IN_ARCHIVE_RECOVERY;`
`438`		`-update_controlfile(datadir_target,&ControlFile_new,do_sync);`
	`438`	`+if (!dry_run)`
	`439`	`+update_controlfile(datadir_target,&ControlFile_new,do_sync);`
`439`	`440`
`440`	`441`	`if (showprogress)`
`441`	`442`	`pg_log_info("syncing target data directory");`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6f3823b

File tree

1 file changed

1 file changed

`‎src/bin/pg_rewind/pg_rewind.c`

0 commit comments