NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit6f1e336

committed

Fix bug that could try to freeze running multixacts.

Commits801c2dc and801c2dc made it possible for vacuum totry to freeze a multixact that is still running. That wasprevented by a check, but raised an error. Repair.Back-patch all the way.Author: Nathan Bossart, Jeremy SchneiderReported-by: Jeremy SchneiderReviewed-by: Jim Nasby, Thomas MunroDiscussion:https://postgr.es/m/DAFB8AFF-2F05-4E33-AD7F-FF8B0F760C17%40amazon.com

1 parentd071a25 commit6f1e336Copy full SHA for 6f1e336

File tree

1 file changed

-2

lines changed

src/backend/commands
- vacuum.c

1 file changed

-2

lines changed

`‎src/backend/commands/vacuum.c`

Lines changed: 8 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -615,6 +615,7 @@ vacuum_set_xid_limits(Relation rel,`
`615`	`615`	`inteffective_multixact_freeze_max_age;`
`616`	`616`	`TransactionIdlimit;`
`617`	`617`	`TransactionIdsafeLimit;`
	`618`	`+MultiXactIdoldestMxact;`
`618`	`619`	`MultiXactIdmxactLimit;`
`619`	`620`	`MultiXactIdsafeMxactLimit;`
`620`	`621`
`@@ -692,7 +693,8 @@ vacuum_set_xid_limits(Relation rel,`
`692`	`693`	`Assert(mxid_freezemin >=0);`
`693`	`694`
`694`	`695`	`/* compute the cutoff multi, being careful to generate a valid value */`
`695`		`-mxactLimit=GetOldestMultiXactId()-mxid_freezemin;`
	`696`	`+oldestMxact=GetOldestMultiXactId();`
	`697`	`+mxactLimit=oldestMxact-mxid_freezemin;`
`696`	`698`	`if (mxactLimit<FirstMultiXactId)`
`697`	`699`	`mxactLimit=FirstMultiXactId;`
`698`	`700`
`@@ -706,7 +708,11 @@ vacuum_set_xid_limits(Relation rel,`
`706`	`708`	`ereport(WARNING,`
`707`	`709`	`(errmsg("oldest multixact is far in the past"),`
`708`	`710`	`errhint("Close open transactions with multixacts soon to avoid wraparound problems.")));`
`709`		`-mxactLimit=safeMxactLimit;`
	`711`	`+/* Use the safe limit, unless an older mxact is still running */`
	`712`	`+if (MultiXactIdPrecedes(oldestMxact,safeMxactLimit))`
	`713`	`+mxactLimit=oldestMxact;`
	`714`	`+else`
	`715`	`+mxactLimit=safeMxactLimit;`
`710`	`716`	`}`
`711`	`717`
`712`	`718`	`*multiXactCutoff=mxactLimit;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6f1e336

File tree

1 file changed

1 file changed

`‎src/backend/commands/vacuum.c`

0 commit comments