NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit6e9ac0a

committed

Avoid formally-undefined use of memcpy() in hstoreUniquePairs().

hstoreUniquePairs() often called memcpy with equal source and destinationpointers. Although this is almost surely harmless in practice, it'sundefined according to the letter of the C standard. Some versions ofvalgrind will complain about it, and some versions of libc as well(cf. commitad520ec). Tweak the code to avoid doing that.Noted by Tomas Vondra. Back-patch to all supported versions becauseof the hazard of libc assertions.Discussion:https://postgr.es/m/bf84d940-90d4-de91-19dd-612e011007f4@fuzzy.cz

1 parentd538f65 commit6e9ac0aCopy full SHA for 6e9ac0a

File tree

1 file changed

-1

lines changed

contrib/hstore
- hstore_io.c

1 file changed

-1

lines changed

`‎contrib/hstore/hstore_io.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -339,7 +339,8 @@ hstoreUniquePairs(Pairs a, int32 l, int32 buflen)`
`339`	`339`	`{`
`340`	`340`	`*buflen+=res->keylen+ ((res->isnull) ?0 :res->vallen);`
`341`	`341`	`res++;`
`342`		`-memcpy(res,ptr,sizeof(Pairs));`
	`342`	`+if (res!=ptr)`
	`343`	`+memcpy(res,ptr,sizeof(Pairs));`
`343`	`344`	`}`
`344`	`345`
`345`	`346`	`ptr++;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6e9ac0a

File tree

1 file changed

1 file changed

`‎contrib/hstore/hstore_io.c`

0 commit comments