NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit6da7d36

committed

Teach pg_dump to dump comments on RLS policy objects.

This was unaccountably omitted in the original RLS patch.The SQL syntax is basically the same as for comments on triggers,so crib code from dumpTrigger().Per report from Marc Munro. Back-patch to all supported branches.Discussion:https://postgr.es/m/1581889298.18009.15.camel@bloodnok.com

1 parent4a97f64 commit6da7d36Copy full SHA for 6da7d36

File tree

1 file changed

+15

-0

lines changed

src/bin/pg_dump
- pg_dump.c

1 file changed

+15

-0

lines changed

`‎src/bin/pg_dump/pg_dump.c`

Lines changed: 15 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -3661,6 +3661,8 @@ dumpPolicy(Archive fout, PolicyInfo polinfo)`
`3661`	`3661`	`TableInfo *tbinfo = polinfo->poltable;`
`3662`	`3662`	`PQExpBuffer query;`
`3663`	`3663`	`PQExpBuffer delqry;`
	`3664`	`+PQExpBuffer polprefix;`
	`3665`	`+char *qtabname;`
`3664`	`3666`	`const char *cmd;`
`3665`	`3667`	`char *tag;`
`3666`	`3668`
`@@ -3718,6 +3720,9 @@ dumpPolicy(Archive fout, PolicyInfo polinfo)`
`3718`	`3720`
`3719`	`3721`	`query = createPQExpBuffer();`
`3720`	`3722`	`delqry = createPQExpBuffer();`
	`3723`	`+polprefix = createPQExpBuffer();`
	`3724`	`+`
	`3725`	`+qtabname = pg_strdup(fmtId(tbinfo->dobj.name));`
`3721`	`3726`
`3722`	`3727`	`appendPQExpBuffer(query, "CREATE POLICY %s", fmtId(polinfo->polname));`
`3723`	`3728`
`@@ -3738,6 +3743,9 @@ dumpPolicy(Archive fout, PolicyInfo polinfo)`
`3738`	`3743`	`appendPQExpBuffer(delqry, "DROP POLICY %s", fmtId(polinfo->polname));`
`3739`	`3744`	`appendPQExpBuffer(delqry, " ON %s;\n", fmtQualifiedDumpable(tbinfo));`
`3740`	`3745`
	`3746`	`+appendPQExpBuffer(polprefix, "POLICY %s ON",`
	`3747`	`+ fmtId(polinfo->polname));`
	`3748`	`+`
`3741`	`3749`	`tag = psprintf("%s %s", tbinfo->dobj.name, polinfo->dobj.name);`
`3742`	`3750`
`3743`	`3751`	`if (polinfo->dobj.dump & DUMP_COMPONENT_POLICY)`
`@@ -3750,9 +3758,16 @@ dumpPolicy(Archive fout, PolicyInfo polinfo)`
`3750`	`3758`	`.createStmt = query->data,`
`3751`	`3759`	`.dropStmt = delqry->data));`
`3752`	`3760`
	`3761`	`+if (polinfo->dobj.dump & DUMP_COMPONENT_COMMENT)`
	`3762`	`+dumpComment(fout, polprefix->data, qtabname,`
	`3763`	`+tbinfo->dobj.namespace->dobj.name, tbinfo->rolname,`
	`3764`	`+polinfo->dobj.catId, 0, polinfo->dobj.dumpId);`
	`3765`	`+`
`3753`	`3766`	`free(tag);`
`3754`	`3767`	`destroyPQExpBuffer(query);`
`3755`	`3768`	`destroyPQExpBuffer(delqry);`
	`3769`	`+destroyPQExpBuffer(polprefix);`
	`3770`	`+free(qtabname);`
`3756`	`3771`	`}`
`3757`	`3772`
`3758`	`3773`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6da7d36

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dump.c`

0 commit comments