NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit6d842be

committed

Provide fast path in snprintf.c for conversion specs that are just "%s".

This case occurs often enough (around 45% of conversion specs executedin our regression tests are just "%s") that it's worth an extra testper conversion spec to allow skipping all the logic associated withfield widths and padding when it happens.Discussion:https://postgr.es/m/26193.1538582367@sss.pgh.pa.us

1 parentabd9ca3 commit6d842beCopy full SHA for 6d842be

File tree

1 file changed

+13

-0

lines changed

src/port
- snprintf.c

1 file changed

+13

-0

lines changed

`‎src/port/snprintf.c`

Lines changed: 13 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -431,6 +431,19 @@ dopr(PrintfTarget target, const char format, va_list args)`
`431`	`431`
`432`	`432`	`/* Process conversion spec starting at format /`
`433`	`433`	`format++;`
	`434`	`+`
	`435`	`+/* Fast path for conversion spec that is exactly %s */`
	`436`	`+if (*format=='s')`
	`437`	`+{`
	`438`	`+format++;`
	`439`	`+strvalue=va_arg(args,char*);`
	`440`	`+Assert(strvalue!=NULL);`
	`441`	`+dostr(strvalue,strlen(strvalue),target);`
	`442`	`+if (target->failed)`
	`443`	`+break;`
	`444`	`+continue;`
	`445`	`+}`
	`446`	`+`
`434`	`447`	`fieldwidth=precision=zpad=leftjust=forcesign=0;`
`435`	`448`	`longflag=longlongflag=pointflag=0;`
`436`	`449`	`fmtpos=accum=0;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6d842be

File tree

1 file changed

1 file changed

`‎src/port/snprintf.c`

0 commit comments