NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit6d4bc96

committed

Avoid unnecessary "touch meson.build" in vpath builds

Ine692727 I added a 'touch meson.build' to configure.ac, to ensureconflicts between in-tree configure based builds and meson builds areautomatically detected. Unfortunately I omitted spaces around the conditionrestricting this to in-tree builds, leading to touch meson.build to also beexecuted in vpath builds. While the only consequence of this buglet is anunnecessary empty file in build directories, it seems worth backpatching.Reported-by: Christoph Berg <myon@debian.org>Discussion:https://postgr.es/m/20240417230002.mb2gv3hyetyn67gk@awork3.anarazel.deBackpatch: 16-, where the meson based build was added

1 parentbb7f195 commit6d4bc96Copy full SHA for 6d4bc96

File tree

2 files changed

-2

lines changed

2 files changed

-2

lines changed

`‎configure`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -20644,6 +20644,6 @@ fi`
`20644`	`20644`
`20645`	`20645`	`# Ensure that any meson build directories would reconfigure and see that`
`20646`	`20646`	`# there's a conflicting in-tree build and can error out.`
`20647`		`-if test "$vpath_build"="no"; then`
	`20647`	`+if test "$vpath_build" ="no"; then`
`20648`	`20648`	`touch meson.build`
`20649`	`20649`	`fi`

`‎configure.ac`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2533,6 +2533,6 @@ AC_OUTPUT`
`2533`	`2533`
`2534`	`2534`	`# Ensure that any meson build directories would reconfigure and see that`
`2535`	`2535`	`# there's a conflicting in-tree build and can error out.`
`2536`		`-if test "$vpath_build"="no"; then`
	`2536`	`+if test "$vpath_build" ="no"; then`
`2537`	`2537`	`touch meson.build`
`2538`	`2538`	`fi`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6d4bc96

File tree

2 files changed

2 files changed

`‎configure`

`‎configure.ac`

0 commit comments