NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit6d2ac55

committed

Fix copy-paste mistake in PQcancelCreate

When an OOM occurred, this function was incorrectly setting a status ofCONNECTION_BAD on the passed in PGconn instead of on the newly createdPGcancelConn.Mistake introduced with61461a3. Backpatch to 17.Author: Jelte Fennema-Nio <postgres@jeltef.nl>Reported-by: Noah Misch <noah@leadboat.com>Discussion:https://postgr.es/m/20240630190040.26.nmisch@google.com

1 parent0f934b0 commit6d2ac55Copy full SHA for 6d2ac55

File tree

1 file changed

-1

lines changed

src/interfaces/libpq
- fe-cancel.c

1 file changed

-1

lines changed

`‎src/interfaces/libpq/fe-cancel.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,7 @@ PQcancelCreate(PGconn *conn)`
`155`	`155`	`return (PGcancelConn*)cancelConn;`
`156`	`156`
`157`	`157`	`oom_error:`
`158`		`-conn->status=CONNECTION_BAD;`
	`158`	`+cancelConn->status=CONNECTION_BAD;`
`159`	`159`	`libpq_append_conn_error(cancelConn,"out of memory");`
`160`	`160`	`return (PGcancelConn*)cancelConn;`
`161`	`161`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6d2ac55

File tree

1 file changed

1 file changed

`‎src/interfaces/libpq/fe-cancel.c‎`

0 commit comments