Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit6cf74f1

Browse files
committed
Fix determination when slot types for upper executor nodes are fixed.
For many queries the fact that the tuple descriptor from the lowernode was not taken into account when determining whether the type of aslot is fixed, lead to tuple deforming for such upper nodes not to beJIT accelerated.I broke this in675af5c.There is ongoing work to enable writing regression tests for relatedbehavior (including a patch that would have detected thisregression), by optionally showing such details in EXPLAIN. But as itseems unlikely that that will be suitable for stable branches, justmerge the fix for now.While it's fairly close to the 12 release window, the fact that 11continues to perform JITed tuple deforming in these cases, thatthere's still cases where we do so in 12, and the fact that theperformance regression can be sizable, weigh in favor of fixing itnow.Author: Andres FreundDiscussion:https://postgr.es/m/20190927072053.njf6prdl3vb7y7qb@alap3.anarazel.deBackpatch: 12-, where675af5c was merged.
1 parent3c70de2 commit6cf74f1

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

‎src/backend/executor/execExpr.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2394,6 +2394,7 @@ ExecComputeSlotInfo(ExprState *state, ExprEvalStep *op)
23942394
{
23952395
isfixed= true;
23962396
tts_ops=parent->innerops;
2397+
desc=ExecGetResultType(is);
23972398
}
23982399
elseif (is)
23992400
{
@@ -2413,6 +2414,7 @@ ExecComputeSlotInfo(ExprState *state, ExprEvalStep *op)
24132414
{
24142415
isfixed= true;
24152416
tts_ops=parent->outerops;
2417+
desc=ExecGetResultType(os);
24162418
}
24172419
elseif (os)
24182420
{

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp