Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit6cea447

Browse files
committed
Disable tests involving ZLIB on Windows for pg_receivewal
As reported by buildfarm member bowerbird, those tests are unstable onWindows. The failure produced there points to a problem with gzflush(),that fails to sync a file freshly-opened, with a gzFile properlyopened. While testing this myself with MSVC, I bumped into a differenterror where a file could simply not be opened, so this makes me ratherdoubtful that testing this area on Windows is a good idea if thisfinishes with random concurrency failures. This requires moreinvestigation, and keeping this buildfarm member red is not a good thingin the long-term, so for now this just disables this set of tests onWindows.Discussion:https://postgr.es/m/YPDLz2x3o1aX2wRh@paquier.xyz
1 parent830ef61 commit6cea447

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

‎src/bin/pg_basebackup/t/020_pg_receivewal.pl‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,13 @@
7272
my@partial_wals =glob"$stream_dir/*\.partial";
7373
is(scalar(@partial_wals), 1,"one partial WAL segment was created");
7474

75-
# Check ZLIB compression if available.
75+
# Check ZLIB compression if available. On Windows, some old versions
76+
# of zlib can cause some instabilities with this test, so disable it
77+
# for now.
7678
SKIP:
7779
{
78-
skip"postgres was not built with ZLIB support", 5
79-
if (!check_pg_config("#define HAVE_LIBZ 1"));
80+
skip"postgres was not built with ZLIB support, or Windows is involved", 5
81+
if (!check_pg_config("#define HAVE_LIBZ 1") ||$windows_os);
8082

8183
# Generate more WAL worth one completed, compressed, segment.
8284
$primary->psql('postgres','SELECT pg_switch_wal();');

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp