NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit6cbdbd9

committed

Add extra descriptive headings in pg_dumpall

Headings are added for the User Configurations and Databases sections,and for each user configuration and database in the output.Author: Fabien CoelhoDiscussion:https://postgr.es/m/alpine.DEB.2.21.1812272222130.32444@lancre

1 parentf092de0 commit6cbdbd9Copy full SHA for 6cbdbd9

File tree

1 file changed

+14

-0

lines changed

src/bin/pg_dump
- pg_dumpall.c

1 file changed

+14

-0

lines changed

`‎src/bin/pg_dump/pg_dumpall.c`

Lines changed: 14 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1346,6 +1346,7 @@ dumpUserConfig(PGconn conn, const char username)`
`1346`	`1346`	`{`
`1347`	`1347`	`PQExpBufferbuf=createPQExpBuffer();`
`1348`	`1348`	`intcount=1;`
	`1349`	`+boolfirst= true;`
`1349`	`1350`
`1350`	`1351`	`for (;;)`
`1351`	`1352`	`{`
`@@ -1367,6 +1368,14 @@ dumpUserConfig(PGconn conn, const char username)`
`1367`	`1368`	`if (PQntuples(res)==1&&`
`1368`	`1369`	`!PQgetisnull(res,0,0))`
`1369`	`1370`	`{`
	`1371`	`+/* comment at section start, only if needed */`
	`1372`	`+if (first)`
	`1373`	`+{`
	`1374`	`+fprintf(OPF,"--\n-- User Configurations\n--\n\n");`
	`1375`	`+first= false;`
	`1376`	`+}`
	`1377`	`+`
	`1378`	`+fprintf(OPF,"--\n-- User Config \"%s\"\n--\n\n",username);`
`1370`	`1379`	`resetPQExpBuffer(buf);`
`1371`	`1380`	`makeAlterConfigCommand(conn,PQgetvalue(res,0,0),`
`1372`	`1381`	`"ROLE",username,NULL,NULL,`
`@@ -1454,6 +1463,9 @@ dumpDatabases(PGconn *conn)`
`1454`	`1463`	`"WHERE datallowconn "`
`1455`	`1464`	`"ORDER BY (datname <> 'template1'), datname");`
`1456`	`1465`
	`1466`	`+if (PQntuples(res)>0)`
	`1467`	`+fprintf(OPF,"--\n-- Databases\n--\n\n");`
	`1468`	`+`
`1457`	`1469`	`for (i=0;i<PQntuples(res);i++)`
`1458`	`1470`	`{`
`1459`	`1471`	`char*dbname=PQgetvalue(res,i,0);`
`@@ -1476,6 +1488,8 @@ dumpDatabases(PGconn *conn)`
`1476`	`1488`	`if (verbose)`
`1477`	`1489`	`fprintf(stderr,_("%s: dumping database \"%s\"...\n"),progname,dbname);`
`1478`	`1490`
	`1491`	`+fprintf(OPF,"--\n-- Database \"%s\" dump\n--\n\n",dbname);`
	`1492`	`+`
`1479`	`1493`	`/*`
`1480`	`1494`	`* We assume that "template1" and "postgres" already exist in the`
`1481`	`1495`	`* target installation. dropDBs() won't have removed them, for fear`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6cbdbd9

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dumpall.c`

0 commit comments