NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit6cb93be

committed

Convert misleading while loop into an if condition

This seems to be leftover fromea15e18 and from when we used to evaluateSRFs at each node.Since there is an unconditional "return" at the end of the loop body, only1 loop is ever possible, so we can just change this into an if condition.There is no actual bug being fixed here so no back-patch. It seems fine tojust fix this anomaly in master only.Author: Greg NancarrowDiscussion:https://postgr.es/m/CAJcOf-d7T1q0az-D8evWXnsuBZjigT04WkV5hCAOEJQZRWy28w@mail.gmail.com

1 parentfbe9b80 commit6cb93beCopy full SHA for 6cb93be

File tree

1 file changed

-1

lines changed

src/backend/executor
- nodeResult.c

1 file changed

-1

lines changed

`‎src/backend/executor/nodeResult.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ ExecResult(PlanState *pstate)`
`103`	`103`	`* called, OR that we failed the constant qual check. Either way, now we`
`104`	`104`	`* are through.`
`105`	`105`	`*/`
`106`		`-while (!node->rs_done)`
	`106`	`+if (!node->rs_done)`
`107`	`107`	`{`
`108`	`108`	`outerPlan=outerPlanState(node);`
`109`	`109`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6cb93be

File tree

1 file changed

1 file changed

`‎src/backend/executor/nodeResult.c`

0 commit comments