NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit6c878a7

committed

Avoid server crash when worker registration fails at execution time.

The previous coding attempts to destroy the DSM in this case, butchild nodes might have stored data there and still be holding ontopointers in this case. So don't do that.Also, free the reader array instead of leaking it.Extracted from two different patch versions both by Amit Kapila.

1 parent74d0d5f commit6c878a7Copy full SHA for 6c878a7

File tree

1 file changed

-1

lines changed

src/backend/executor
- nodeGather.c

1 file changed

-1

lines changed

`‎src/backend/executor/nodeGather.c`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -190,7 +190,7 @@ ExecGather(GatherState *node)`
`190`	`190`
`191`	`191`	`/* No workers? Then never mind. */`
`192`	`192`	`if (!got_any_worker)`
`193`		`-ExecShutdownGather(node);`
	`193`	`+ExecShutdownGatherWorkers(node);`
`194`	`194`	`}`
`195`	`195`
`196`	`196`	`/* Run plan locally if no workers or not single-copy. */`
`@@ -402,6 +402,8 @@ ExecShutdownGatherWorkers(GatherState *node)`
`402`	`402`
`403`	`403`	`for (i=0;i<node->nreaders;++i)`
`404`	`404`	`DestroyTupleQueueReader(node->reader[i]);`
	`405`	`+`
	`406`	`+pfree(node->reader);`
`405`	`407`	`node->reader=NULL;`
`406`	`408`	`}`
`407`	`409`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6c878a7

File tree

1 file changed

1 file changed

`‎src/backend/executor/nodeGather.c`

0 commit comments