NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit6c75fb6

committed

Ensure that num_sync is greater than zero in synchronous_standby_names.

Previously num_sync could be set to zero and this setting causedan assertion failure. This means that multiple synchronous standbyscode should assume that num_sync is greater than zero.Also setting num_sync to zero is nonsense because it's basicallythe configuration for synchronous replication. If users want not tomake transaction commits wait for any standbys,synchronous_standby_names should be emptied to disable synchronousreplication instead of setting num_sync to zero.This patch forbids users from setting num_sync to zero insynchronous_standby_names. If zero is specified, an error willhappen during processing the parameter settings.Back-patch to 9.6 where multiple synchronous standbys feature was added.Patch by me. Reviewed by Tom Lane.Discussion: <CAHGQGwHWB3izc6cXuFLh5kOcAbFXaRhhgwd-X5PeN9TEjxqXwg@mail.gmail.com>

1 parent6f73455 commit6c75fb6Copy full SHA for 6c75fb6

File tree

1 file changed

-0

lines changed

src/backend/replication
- syncrep.c

1 file changed

-0

lines changed

`‎src/backend/replication/syncrep.c`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -922,6 +922,13 @@ check_synchronous_standby_names(char newval, void extra, GucSource source)`
`922`	`922`	`return false;`
`923`	`923`	`}`
`924`	`924`
	`925`	`+if (syncrep_parse_result->num_sync <=0)`
	`926`	`+{`
	`927`	`+GUC_check_errmsg("number of synchronous standbys (%d) must be greater than zero",`
	`928`	`+syncrep_parse_result->num_sync);`
	`929`	`+return false;`
	`930`	`+}`
	`931`	`+`
`925`	`932`	`/* GUC extra value must be malloc'd, not palloc'd */`
`926`	`933`	`pconf= (SyncRepConfigData*)`
`927`	`934`	`malloc(syncrep_parse_result->config_size);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6c75fb6

File tree

1 file changed

1 file changed

`‎src/backend/replication/syncrep.c`

0 commit comments