NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit6c426cd

committed

Fix race condition in statext_store().

Must hold some lock on the pg_statistic_ext_data catalog *before*we look up the tuple we aim to replace. Otherwise a concurrentVACUUM FULL or similar operation could move it to a different TID,leaving us trying to replace the wrong tuple.Back-patch to v12 where this got broken.Credit goes to Dean Rasheed; I'm just doing the clerical work.Discussion:https://postgr.es/m/CAEZATCU0zHMDiQV0g8P2U+YSP9C1idUPrn79DajsbonwkN0xvQ@mail.gmail.com

1 parent1fd0eee commit6c426cdCopy full SHA for 6c426cd

File tree

1 file changed

-3

lines changed

src/backend/statistics
- extended_stats.c

1 file changed

-3

lines changed

`‎src/backend/statistics/extended_stats.c‎`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -322,12 +322,14 @@ statext_store(Oid statOid,`
`322`	`322`	`MVNDistinctndistinct,MVDependenciesdependencies,`
`323`	`323`	`MCVListmcv,VacAttrStats*stats)`
`324`	`324`	`{`
	`325`	`+Relationpg_stextdata;`
`325`	`326`	`HeapTuplestup,`
`326`	`327`	`oldtup;`
`327`	`328`	`Datumvalues[Natts_pg_statistic_ext_data];`
`328`	`329`	`boolnulls[Natts_pg_statistic_ext_data];`
`329`	`330`	`boolreplaces[Natts_pg_statistic_ext_data];`
`330`		`-Relationpg_stextdata;`
	`331`	`+`
	`332`	`+pg_stextdata=table_open(StatisticExtDataRelationId,RowExclusiveLock);`
`331`	`333`
`332`	`334`	`memset(nulls, true,sizeof(nulls));`
`333`	`335`	`memset(replaces, false,sizeof(replaces));`
`@@ -371,8 +373,6 @@ statext_store(Oid statOid,`
`371`	`373`	`elog(ERROR,"cache lookup failed for statistics object %u",statOid);`
`372`	`374`
`373`	`375`	`/* replace it */`
`374`		`-pg_stextdata=table_open(StatisticExtDataRelationId,RowExclusiveLock);`
`375`		`-`
`376`	`376`	`stup=heap_modify_tuple(oldtup,`
`377`	`377`	`RelationGetDescr(pg_stextdata),`
`378`	`378`	`values,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6c426cd

File tree

1 file changed

1 file changed

`‎src/backend/statistics/extended_stats.c‎`

0 commit comments