forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit6c3c9d4
committed
Defer restoration of libraries in parallel workers.
Several users of extensions complained of crashes in parallel workersthat turned out to be due to syscache access from their _PG_init()functions. Reorder the initialization of parallel workers so thatlibraries are restored after the caches are initialized, and inside atransaction.This was reported in bug #15350 and elsewhere. We don't consider itto be a bug: extensions shouldn't do that, because then they can't beused in shared_preload_libraries. However, it's a fairly obscurehazard and these extensions worked in practice before parallel querycame along. So let's make it work. Later commits might add a warningmessage and eventually an error.Back-patch to 9.6, where parallel query landed.Author: Thomas MunroReviewed-by: Amit KapilaReported-by: Kieran McCusker, JimmyDiscussion:https://postgr.es/m/153512195228.1489.8545997741965926448%40wrigleys.postgresql.org1 parent40cfe86 commit6c3c9d4
1 file changed
+9
-9
lines changedLines changed: 9 additions & 9 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1311 | 1311 |
| |
1312 | 1312 |
| |
1313 | 1313 |
| |
1314 |
| - | |
1315 |
| - | |
1316 |
| - | |
1317 |
| - | |
1318 |
| - | |
1319 |
| - | |
1320 |
| - | |
1321 |
| - | |
1322 | 1314 |
| |
1323 | 1315 |
| |
1324 | 1316 |
| |
| |||
1341 | 1333 |
| |
1342 | 1334 |
| |
1343 | 1335 |
| |
| 1336 | + | |
| 1337 | + | |
| 1338 | + | |
| 1339 | + | |
| 1340 | + | |
| 1341 | + | |
| 1342 | + | |
| 1343 | + | |
| 1344 | + | |
1344 | 1345 |
| |
1345 | 1346 |
| |
1346 |
| - | |
1347 | 1347 |
| |
1348 | 1348 |
| |
1349 | 1349 |
| |
|
0 commit comments
Comments
(0)