Commit6c06bc2

committed

Make 'dummy' declarations in header files be 'extern int no_such_variable'

instead of 'extern int errno'; the latter is unsafe according to theANSI C standard, as well as in practice on some platforms.

1 parentdad34ba commit6c06bc2Copy full SHA for 6c06bc2

File tree

-11

lines changed

-11

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`* Portions Copyright (c) 1996-2002, PostgreSQL Global Development Group`
`9`	`9`	`* Portions Copyright (c) 1994, Regents of the University of California`
`10`	`10`	`*`
`11`		`- * $Id: indexing.h,v 1.75 2002/09/04 20:31:37 momjian Exp $`
	`11`	`+ * $Id: indexing.h,v 1.76 2002/10/18 20:33:57 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -98,8 +98,8 @@ extern void CatalogUpdateIndexes(Relation heapRel, HeapTuple heapTuple);`
`98`	`98`	`* These macros are just to keep the C compiler from spitting up on the`
`99`	`99`	`* upcoming commands for genbki.sh.`
`100`	`100`	`*/`
`101`		`-#defineDECLARE_INDEX(x) extern interrno`
`102`		`-#defineDECLARE_UNIQUE_INDEX(x) extern interrno`
	`101`	`+#defineDECLARE_INDEX(x) extern intno_such_variable`
	`102`	`+#defineDECLARE_UNIQUE_INDEX(x) extern intno_such_variable`
`103`	`103`	`#defineBUILD_INDICES`
`104`	`104`
`105`	`105`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`* Portions Copyright (c) 1996-2002, PostgreSQL Global Development Group`
`11`	`11`	`* Portions Copyright (c) 1995, Regents of the University of California`
`12`	`12`	`*`
`13`		`- * $Id: postgres.h,v 1.61 2002/09/04 20:31:36 momjian Exp $`
	`13`	`+ * $Id: postgres.h,v 1.62 2002/10/18 20:33:57 tgl Exp $`
`14`	`14`	`*`
`15`	`15`	`*-------------------------------------------------------------------------`
`16`	`16`	`*/`
`@@ -539,8 +539,8 @@ extern int ExceptionalCondition(char conditionName, char errorType,`
`539`	`539`	`#defineBKI_WITHOUT_OIDS`
`540`	`540`
`541`	`541`	`/* these need to expand into some harmless, repeatable declaration */`
`542`		`-#defineDATA(x) extern interrno`
`543`		`-#defineDESCR(x) extern interrno`
	`542`	`+#defineDATA(x) extern intno_such_variable`
	`543`	`+#defineDESCR(x) extern intno_such_variable`
`544`	`544`
`545`	`545`	`#defineBKI_BEGIN`
`546`	`546`	`#defineBKI_END`

Lines changed: 1 addition & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -177,11 +177,7 @@ __DATA__`
`177`	`177`	`#endif`
`178`	`178`
`179`	`179`	`#ifndefdTHR`
`180`		`-#ifdefWIN32`
`181`		`-#definedTHR extern int Perl___notused`
`182`		`-#else`
`183`		`-#definedTHR extern int errno`
`184`		`-#endif`
	`180`	`+#definedTHR extern int no_such_variable`
`185`	`181`	`#endif`
`186`	`182`
`187`	`183`	`#ifndefboolSV`

Comments

(0)