NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit6beb38c

committed

Make new test immune to collation

Animals running in Czech locale failed. I could try to find table namesthat don't have this problem, but it seems simpler to just use the Clocale.Per buildfarm

1 parent80ba4bb commit6beb38cCopy full SHA for 6beb38c

File tree

2 files changed

-4

lines changed

src/test/regress
- expected
  - triggers.out
- sql
  - triggers.sql

2 files changed

-4

lines changed

`‎src/test/regress/expected/triggers.out`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -3425,7 +3425,7 @@ alter trigger a on grandparent rename to b;`
`3425`	`3425`	`select tgrelid::regclass, tgname,`
`3426`	`3426`	`(select tgname from pg_trigger tr where tr.oid = pg_trigger.tgparentid) parent_tgname`
`3427`	`3427`	`from pg_trigger where tgrelid in (select relid from pg_partition_tree('grandparent'))`
`3428`		`-order by tgname, tgrelid::regclass::text;`
	`3428`	`+order by tgname, tgrelid::regclass::text COLLATE "C";`
`3429`	`3429`	`tgrelid \| tgname \| parent_tgname`
`3430`	`3430`	`-------------+--------+---------------`
`3431`	`3431`	`chi \| b \| b`
`@@ -3452,7 +3452,7 @@ alter trigger p on grandparent rename to q;`
`3452`	`3452`	`select tgrelid::regclass, tgname,`
`3453`	`3453`	`(select tgname from pg_trigger tr where tr.oid = pg_trigger.tgparentid) parent_tgname`
`3454`	`3454`	`from pg_trigger where tgrelid in (select relid from pg_partition_tree('grandparent'))`
`3455`		`-order by tgname, tgrelid::regclass::text;`
	`3455`	`+order by tgname, tgrelid::regclass::text COLLATE "C";`
`3456`	`3456`	`tgrelid \| tgname \| parent_tgname`
`3457`	`3457`	`-------------+--------+---------------`
`3458`	`3458`	`chi \| b \| b`

`‎src/test/regress/sql/triggers.sql`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -2589,7 +2589,7 @@ alter trigger a on grandparent rename to b;`
`2589`	`2589`	`select tgrelid::regclass, tgname,`
`2590`	`2590`	`(select tgnamefrom pg_trigger trwheretr.oid=pg_trigger.tgparentid) parent_tgname`
`2591`	`2591`	`from pg_triggerwhere tgrelidin (select relidfrom pg_partition_tree('grandparent'))`
`2592`		`-order by tgname, tgrelid::regclass::text;`
	`2592`	`+order by tgname, tgrelid::regclass::text COLLATE"C";`
`2593`	`2593`	`altertrigger aon only grandparent rename to b;-- ONLY not supported`
`2594`	`2594`	`altertrigger bon middle rename to c;-- can't rename trigger on partition`
`2595`	`2595`	`createtriggerc after inserton middle`
`@@ -2603,7 +2603,7 @@ alter trigger p on grandparent rename to q;`
`2603`	`2603`	`select tgrelid::regclass, tgname,`
`2604`	`2604`	`(select tgnamefrom pg_trigger trwheretr.oid=pg_trigger.tgparentid) parent_tgname`
`2605`	`2605`	`from pg_triggerwhere tgrelidin (select relidfrom pg_partition_tree('grandparent'))`
`2606`		`-order by tgname, tgrelid::regclass::text;`
	`2606`	`+order by tgname, tgrelid::regclass::text COLLATE"C";`
`2607`	`2607`
`2608`	`2608`	`droptable grandparent;`
`2609`	`2609`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6beb38c

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/triggers.out`

`‎src/test/regress/sql/triggers.sql`

0 commit comments