Commit6be84ee

committed

Update more comments for96198d9.

Etsuro Fujita, reviewed (though not completely endorsed) by AshutoshBapat, and slightly expanded by me.

1 parent74a379b commit6be84eeCopy full SHA for 6be84ee

File tree

-6

lines changed

-6

lines changed

Lines changed: 2 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -3349,10 +3349,8 @@ postgresImportForeignSchema(ImportForeignSchemaStmt *stmt, Oid serverOid)`
`3349`	`3349`	`*`
`3350`	`3350`	`* 1) Join type is INNER or OUTER (one of LEFT/RIGHT/FULL)`
`3351`	`3351`	`* 2) Both outer and inner portions are safe to push-down`
`3352`		`- * 3) All foreign tables in the join belong to the same foreign server and use`
`3353`		`- * the same user mapping.`
`3354`		`- * 4) All join conditions are safe to push down`
`3355`		`- * 5) No relation has local filter (this can be relaxed for INNER JOIN, if we`
	`3352`	`+ * 3) All join conditions are safe to push down`
	`3353`	`+ * 4) No relation has local filter (this can be relaxed for INNER JOIN, if we`
`3356`	`3354`	`* can move unpushable clauses upwards in the join tree).`
`3357`	`3355`	`*/`
`3358`	`3356`	`staticbool`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -213,7 +213,8 @@ add_paths_to_joinrel(PlannerInfo *root,`
`213`	`213`
`214`	`214`	`/*`
`215`	`215`	`* 5. If inner and outer relations are foreign tables (or joins) belonging`
`216`		`- * to the same server, give the FDW a chance to push down joins.`
	`216`	`+ * to the same server and using the same user mapping, give the FDW a`
	`217`	`+ * chance to push down joins.`
`217`	`218`	`*/`
`218`	`219`	`if (joinrel->fdwroutine&&`
`219`	`220`	`joinrel->fdwroutine->GetForeignJoinPaths)`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -448,9 +448,11 @@ typedef struct PlannerInfo`
`448`	`448`	`*in just as for a baserel, except we don't bother with lateral_vars.`
`449`	`449`	`*`
`450`	`450`	`* If the relation is either a foreign table or a join of foreign tables that`
`451`		`- * all belong to the same foreign server, these fields will be set:`
	`451`	`+ * all belong to the same foreign server and use the same user mapping, these`
	`452`	`+ * fields will be set:`
`452`	`453`	`*`
`453`	`454`	`*serverid - OID of foreign server, if foreign table (else InvalidOid)`
	`455`	`+ *umid - OID of user mapping, if foreign table (else InvalidOid)`
`454`	`456`	`*fdwroutine - function hooks for FDW, if foreign table (else NULL)`
`455`	`457`	`*fdw_private - private state for FDW, if foreign table (else NULL)`
`456`	`458`	`*`

Comments

(0)