Commit6be725e

committed

Fix redundant error messages in client tools

1 parenteed4356 commit6be725eCopy full SHA for 6be725e

File tree

-5

lines changed

-5

lines changed

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -200,8 +200,7 @@ GetConnection(void)`
`200`	`200`
`201`	`201`	`if (PQstatus(tmpconn)!=CONNECTION_OK)`
`202`	`202`	`{`
`203`		`-pg_log_error("could not connect to server: %s",`
`204`		`-PQerrorMessage(tmpconn));`
	`203`	`+pg_log_error("%s",PQerrorMessage(tmpconn));`
`205`	`204`	`PQfinish(tmpconn);`
`206`	`205`	`free(values);`
`207`	`206`	`free(keywords);`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -282,8 +282,7 @@ main(int argc, char **argv)`
`282`	`282`	`conn=PQconnectdb(connstr_source);`
`283`	`283`
`284`	`284`	`if (PQstatus(conn)==CONNECTION_BAD)`
`285`		`-pg_fatal("could not connect to server: %s",`
`286`		`-PQerrorMessage(conn));`
	`285`	`+pg_fatal("%s",PQerrorMessage(conn));`
`287`	`286`
`288`	`287`	`if (showprogress)`
`289`	`288`	`pg_log_info("connected to server");`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -295,7 +295,7 @@ main(int argc, char *argv[])`
`295`	`295`
`296`	`296`	`if (PQstatus(pset.db)==CONNECTION_BAD)`
`297`	`297`	`{`
`298`		`-pg_log_error("could not connect to server:%s",PQerrorMessage(pset.db));`
	`298`	`+pg_log_error("%s",PQerrorMessage(pset.db));`
`299`	`299`	`PQfinish(pset.db);`
`300`	`300`	`exit(EXIT_BADCONN);`
`301`	`301`	`}`

Comments

(0)