NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit6bda2af

committed

Fix bug that could try to freeze running multixacts.

Commits801c2dc and801c2dc made it possible for vacuum totry to freeze a multixact that is still running. That wasprevented by a check, but raised an error. Repair.Back-patch all the way.Author: Nathan Bossart, Jeremy SchneiderReported-by: Jeremy SchneiderReviewed-by: Jim Nasby, Thomas MunroDiscussion:https://postgr.es/m/DAFB8AFF-2F05-4E33-AD7F-FF8B0F760C17%40amazon.com

1 parent0d21f91 commit6bda2afCopy full SHA for 6bda2af

File tree

1 file changed

-2

lines changed

src/backend/commands
- vacuum.c

1 file changed

-2

lines changed

`‎src/backend/commands/vacuum.c`

Lines changed: 8 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -893,6 +893,7 @@ vacuum_set_xid_limits(Relation rel,`
`893`	`893`	`inteffective_multixact_freeze_max_age;`
`894`	`894`	`TransactionIdlimit;`
`895`	`895`	`TransactionIdsafeLimit;`
	`896`	`+MultiXactIdoldestMxact;`
`896`	`897`	`MultiXactIdmxactLimit;`
`897`	`898`	`MultiXactIdsafeMxactLimit;`
`898`	`899`
`@@ -970,7 +971,8 @@ vacuum_set_xid_limits(Relation rel,`
`970`	`971`	`Assert(mxid_freezemin >=0);`
`971`	`972`
`972`	`973`	`/* compute the cutoff multi, being careful to generate a valid value */`
`973`		`-mxactLimit=GetOldestMultiXactId()-mxid_freezemin;`
	`974`	`+oldestMxact=GetOldestMultiXactId();`
	`975`	`+mxactLimit=oldestMxact-mxid_freezemin;`
`974`	`976`	`if (mxactLimit<FirstMultiXactId)`
`975`	`977`	`mxactLimit=FirstMultiXactId;`
`976`	`978`
`@@ -984,7 +986,11 @@ vacuum_set_xid_limits(Relation rel,`
`984`	`986`	`ereport(WARNING,`
`985`	`987`	`(errmsg("oldest multixact is far in the past"),`
`986`	`988`	`errhint("Close open transactions with multixacts soon to avoid wraparound problems.")));`
`987`		`-mxactLimit=safeMxactLimit;`
	`989`	`+/* Use the safe limit, unless an older mxact is still running */`
	`990`	`+if (MultiXactIdPrecedes(oldestMxact,safeMxactLimit))`
	`991`	`+mxactLimit=oldestMxact;`
	`992`	`+else`
	`993`	`+mxactLimit=safeMxactLimit;`
`988`	`994`	`}`
`989`	`995`
`990`	`996`	`*multiXactCutoff=mxactLimit;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6bda2af

File tree

1 file changed

1 file changed

`‎src/backend/commands/vacuum.c`

0 commit comments