forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit6ba4ecb
committed
Remove most volatile qualifiers from xlog.c
For the reason outlined indf4077c also remove volatile qualifiersfrom xlog.c. Some of these uses of volatile have been added afternoticing problems back when spinlocks didn't imply compilerbarriers. So they are a good test - in fact removing the volatilesbreaks when done without the barriers in spinlocks present.Several uses of volatile remain where they are explicitly used toaccess shared memory without locks. These locations are ok withslightly out of date data, but removing the volatile might lead to thevariables never being reread from memory. These uses could also bereplaced by barriers, but that's a separate change of doubtful value.1 parentdf4077c commit6ba4ecb
1 file changed
+173
-297
lines changed0 commit comments
Comments
(0)