Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit6b85489

Browse files
committed
Fix inconsistencies in the code
This addresses a couple of issues in the code:- Typos and inconsistencies in comments and function declarations.- Removal of unreferenced function declarations.- Removal of unnecessary compile flags.- A cleanup error in regressplans.sh.Author: Alexander LakhinDiscussion:https://postgr.es/m/0c991fdf-2670-1997-c027-772a420c4604@gmail.com
1 parent7e9a4c5 commit6b85489

File tree

37 files changed

+52
-62
lines changed

37 files changed

+52
-62
lines changed

‎contrib/cube/cube.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -590,7 +590,7 @@ g_cube_picksplit(PG_FUNCTION_ARGS)
590590
v->spl_nright++;
591591
}
592592
}
593-
*left=*right=FirstOffsetNumber;/* sentinel value, see dosplit() */
593+
*left=*right=FirstOffsetNumber;/* sentinel value */
594594

595595
v->spl_ldatum=PointerGetDatum(datum_l);
596596
v->spl_rdatum=PointerGetDatum(datum_r);

‎doc/src/sgml/catalogs.sgml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11036,7 +11036,7 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx
1103611036
<entry><structfield>kinds</structfield></entry>
1103711037
<entry><type>text[]</type></entry>
1103811038
<entry></entry>
11039-
<entry>Types ofexdended statistics enabled for this record</entry>
11039+
<entry>Types ofextended statistics enabled for this record</entry>
1104011040
</row>
1104111041

1104211042
<row>

‎doc/src/sgml/gist.sgml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -910,7 +910,7 @@ Datum
910910
my_fetch(PG_FUNCTION_ARGS)
911911
{
912912
GISTENTRY *entry = (GISTENTRY *) PG_GETARG_POINTER(0);
913-
input_data_type *in =DatumGetP(entry->key);
913+
input_data_type *in =DatumGetPointer(entry->key);
914914
fetched_data_type *fetched_data;
915915
GISTENTRY *retval;
916916

‎src/backend/access/transam/multixact.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -367,8 +367,10 @@ static bool SetOffsetVacuumLimit(bool is_startup);
367367
staticboolfind_multixact_start(MultiXactIdmulti,MultiXactOffset*result);
368368
staticvoidWriteMZeroPageXlogRec(intpageno,uint8info);
369369
staticvoidWriteMTruncateXlogRec(OidoldestMultiDB,
370-
MultiXactIdstartOff,MultiXactIdendOff,
371-
MultiXactOffsetstartMemb,MultiXactOffsetendMemb);
370+
MultiXactIdstartTruncOff,
371+
MultiXactIdendTruncOff,
372+
MultiXactOffsetstartTruncMemb,
373+
MultiXactOffsetendTruncMemb);
372374

373375

374376
/*
@@ -2784,7 +2786,7 @@ ReadMultiXactCounts(uint32 *multixacts, MultiXactOffset *members)
27842786

27852787
/*
27862788
* Multixact members can be removed once the multixacts that refer to them
2787-
* are older than everydatminxmid. autovacuum_multixact_freeze_max_age and
2789+
* are older than everydatminmxid. autovacuum_multixact_freeze_max_age and
27882790
* vacuum_multixact_freeze_table_age work together to make sure we never have
27892791
* too many multixacts; we hope that, at least under normal circumstances,
27902792
* this will also be sufficient to keep us from using too many offsets.

‎src/backend/catalog/aclchk.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1641,7 +1641,7 @@ expand_all_col_privileges(Oid table_oid, Form_pg_class classForm,
16411641

16421642
/*
16431643
*This processes attributes, but expects to be called from
1644-
*ExecGrant_Relation, not directly fromExecGrantStmt.
1644+
*ExecGrant_Relation, not directly fromExecuteGrantStmt.
16451645
*/
16461646
staticvoid
16471647
ExecGrant_Attribute(InternalGrant*istmt,OidrelOid,constchar*relname,

‎src/backend/catalog/namespace.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -504,9 +504,9 @@ RangeVarGetCreationNamespace(const RangeVar *newRelation)
504504
* permission on the target namespace, this function will instead signal
505505
* an ERROR.
506506
*
507-
* If non-NULL, *existing_oid is set to the OID of any existing relation with
508-
* the same name which already exists in that namespace, or to InvalidOid if
509-
* no such relation exists.
507+
* If non-NULL, *existing_relation_id is set to the OID of any existing relation
508+
*withthe same name which already exists in that namespace, or to InvalidOid
509+
*ifno such relation exists.
510510
*
511511
* If lockmode != NoLock, the specified lock mode is acquired on the existing
512512
* relation, if any, provided that the current user owns the target relation.

‎src/backend/executor/README

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,9 +186,9 @@ Expression Evaluation
186186

187187
To allow for different methods of expression evaluation, and for
188188
better branch/jump target prediction, expressions are evaluated by
189-
calling ExprState->evalfunc (viaExprEvalExpr() and friends).
189+
calling ExprState->evalfunc (viaExecEvalExpr() and friends).
190190

191-
ExprReadyExpr() can choose the method of interpretation by setting
191+
ExecReadyExpr() can choose the method of interpretation by setting
192192
evalfunc to an appropriate function. The default execution function,
193193
ExecInterpExpr, is implemented in execExprInterp.c; see its header
194194
comment for details. Special-case evalfuncs are used for certain

‎src/backend/executor/execScan.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,7 @@ ExecScanFetch(ScanState *node,
9898
*ExecScan
9999
*
100100
*Scans the relation using the 'access method' indicated and
101-
*returns the next qualifying tuple in the direction specified
102-
*in the global variable ExecDirection.
101+
*returns the next qualifying tuple.
103102
*The access method returns the next tuple and ExecScan() is
104103
*responsible for checking the tuple returned against the qual-clause.
105104
*

‎src/backend/executor/execTuples.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1148,7 +1148,7 @@ ExecAllocTableSlot(List **tupleTable, TupleDesc desc,
11481148
*This releases any resources (buffer pins, tupdesc refcounts)
11491149
*held by the tuple table, and optionally releases the memory
11501150
*occupied by the tuple table data structure.
1151-
*It is expected that this routine be called byEndPlan().
1151+
*It is expected that this routine be called byExecEndPlan().
11521152
* --------------------------------
11531153
*/
11541154
void

‎src/backend/executor/nodeProjectSet.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -196,8 +196,8 @@ ExecProjectSRF(ProjectSetState *node, bool continuing)
196196
Assert(hassrf);
197197

198198
/*
199-
* If all the SRFs returnedEndResult, we consider that as no row being
200-
* produced.
199+
* If all the SRFs returnedExprEndResult, we consider that as no row
200+
*beingproduced.
201201
*/
202202
if (hasresult)
203203
{

‎src/backend/executor/nodeRecursiveunion.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ ExecRecursiveUnion(PlanState *pstate)
160160
}
161161

162162
/* ----------------------------------------------------------------
163-
*ExecInitRecursiveUnionScan
163+
*ExecInitRecursiveUnion
164164
* ----------------------------------------------------------------
165165
*/
166166
RecursiveUnionState*
@@ -263,7 +263,7 @@ ExecInitRecursiveUnion(RecursiveUnion *node, EState *estate, int eflags)
263263
}
264264

265265
/* ----------------------------------------------------------------
266-
*ExecEndRecursiveUnionScan
266+
*ExecEndRecursiveUnion
267267
*
268268
*frees any storage allocated through C routines.
269269
* ----------------------------------------------------------------

‎src/backend/lib/dshash.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -409,7 +409,7 @@ dshash_find(dshash_table *hash_table, const void *key, bool exclusive)
409409
}
410410
else
411411
{
412-
/* The caller will free the lock by callingdshash_release. */
412+
/* The caller will free the lock by callingdshash_release_lock. */
413413
hash_table->find_locked= true;
414414
hash_table->find_exclusively_locked=exclusive;
415415
returnENTRY_FROM_ITEM(item);

‎src/backend/postmaster/autovacuum.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1069,7 +1069,7 @@ rebuild_database_list(Oid newdb)
10691069
current_time=GetCurrentTimestamp();
10701070

10711071
/*
1072-
* move the elements from the array into thedllist, setting the
1072+
* move the elements from the array into thedlist, setting the
10731073
* next_worker while walking the array
10741074
*/
10751075
for (i=0;i<nelems;i++)

‎src/backend/replication/basebackup.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1074,7 +1074,7 @@ sendDir(const char *path, int basepathlen, bool sizeonly, List *tablespaces,
10741074
* error in that case. The error handler further up will call
10751075
* do_pg_abort_backup() for us. Also check that if the backup was
10761076
* started while still in recovery, the server wasn't promoted.
1077-
*dp_pg_stop_backup() will check that too, but it's better to stop
1077+
*do_pg_stop_backup() will check that too, but it's better to stop
10781078
* the backup early than continue to the end and fail there.
10791079
*/
10801080
CHECK_FOR_INTERRUPTS();

‎src/backend/storage/buffer/localbuf.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,7 @@ DropRelFileNodeLocalBuffers(RelFileNode rnode, ForkNumber forkNum,
361361
*This function removes from the buffer pool all pages of all forks
362362
*of the specified relation.
363363
*
364-
*SeeDropRelFileNodeAllBuffers in bufmgr.c for more notes.
364+
*SeeDropRelFileNodesAllBuffers in bufmgr.c for more notes.
365365
*/
366366
void
367367
DropRelFileNodeAllLocalBuffers(RelFileNodernode)

‎src/backend/storage/ipc/procarray.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1428,10 +1428,11 @@ GetOldestXmin(Relation rel, int flags)
14281428
result=replication_slot_xmin;
14291429

14301430
/*
1431-
* After locks have been released and defer_cleanup_age has been applied,
1432-
* check whether we need to back up further to make logical decoding
1433-
* possible. We need to do so if we're computing the global limit (rel =
1434-
* NULL) or if the passed relation is a catalog relation of some kind.
1431+
* After locks have been released and vacuum_defer_cleanup_age has been
1432+
* applied, check whether we need to back up further to make logical
1433+
* decoding possible. We need to do so if we're computing the global limit
1434+
* (rel = NULL) or if the passed relation is a catalog relation of some
1435+
* kind.
14351436
*/
14361437
if (!(flags&PROCARRAY_SLOTS_XMIN)&&
14371438
(rel==NULL||

‎src/backend/storage/lmgr/predicate.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4360,7 +4360,7 @@ CheckTargetForConflictsIn(PREDICATELOCKTARGETTAG *targettag)
43604360
/*
43614361
* If we found one of our own SIREAD locks to remove, remove it now.
43624362
*
4363-
* At this point our transaction already hasan ExclusiveRowLock on the
4363+
* At this point our transaction already hasa RowExclusiveLock on the
43644364
* relation, so we are OK to drop the predicate lock on the tuple, if
43654365
* found, without fearing that another write against the tuple will occur
43664366
* before the MVCC information makes it to the buffer.

‎src/backend/storage/smgr/md.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1163,9 +1163,6 @@ _mdfd_getseg(SMgrRelation reln, ForkNumber forknum, BlockNumber blkno,
11631163
* replaying WAL data that has a write into a high-numbered
11641164
* segment of a relation that was later deleted. We want to go
11651165
* ahead and create the segments so we can finish out the replay.
1166-
* However if the caller has specified
1167-
* EXTENSION_REALLY_RETURN_NULL, then extension is not desired
1168-
* even in recovery; we won't reach this point in that case.
11691166
*
11701167
* We have to maintain the invariant that segments before the last
11711168
* active segment are of size RELSEG_SIZE; therefore, if

‎src/backend/utils/adt/tsrank.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -738,7 +738,7 @@ get_docrep(TSVector txt, QueryRepresentation *qr, int *doclen)
738738
doc= (DocRepresentation*)palloc(sizeof(DocRepresentation)*len);
739739

740740
/*
741-
* Iterate through query to makeDocRepresentaion for words and it's
741+
* Iterate through query to makeDocRepresentation for words and it's
742742
* entries satisfied by query
743743
*/
744744
for (i=0;i<qr->query->size;i++)

‎src/backend/utils/misc/tzparser.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,7 @@ validateTzEntry(tzEntry *tzentry)
5353
unsignedchar*p;
5454

5555
/*
56-
* Check restrictions imposed by datetkntbl storage format (see
57-
* datetime.c)
56+
* Check restrictions imposed by datetktbl storage format (see datetime.c)
5857
*/
5958
if (strlen(tzentry->abbrev)>TOKMAXLEN)
6059
{

‎src/bin/pg_dump/pg_backup_db.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,7 @@ notice_processor(void *arg, const char *message)
378378
pg_log_generic(PG_LOG_INFO,"%s",message);
379379
}
380380

381-
/* Likeexit_fatal(), but with a complaint about a particular query. */
381+
/* Likefatal(), but with a complaint about a particular query. */
382382
staticvoid
383383
die_on_query_failure(ArchiveHandle*AH,constchar*query)
384384
{

‎src/include/access/heapam.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ extern TableScanDesc heap_beginscan(Relation relation, Snapshot snapshot,
112112
ParallelTableScanDescparallel_scan,
113113
uint32flags);
114114
externvoidheap_setscanlimits(TableScanDescscan,BlockNumberstartBlk,
115-
BlockNumberendBlk);
115+
BlockNumbernumBlks);
116116
externvoidheapgetpage(TableScanDescscan,BlockNumberpage);
117117
externvoidheap_rescan(TableScanDescscan,ScanKeykey,boolset_params,
118118
boolallow_strat,boolallow_sync,boolallow_pagemode);

‎src/include/access/timeline.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ extern void writeTimeLineHistory(TimeLineID newTLI, TimeLineID parentTLI,
3636
XLogRecPtrswitchpoint,char*reason);
3737
externvoidwriteTimeLineHistoryFile(TimeLineIDtli,char*content,intsize);
3838
externvoidrestoreTimeLineHistoryFiles(TimeLineIDbegin,TimeLineIDend);
39-
externbooltliInHistory(TimeLineIDtli,List*expectedTLIs);
39+
externbooltliInHistory(TimeLineIDtli,List*expectedTLEs);
4040
externTimeLineIDtliOfPointInHistory(XLogRecPtrptr,List*history);
4141
externXLogRecPtrtliSwitchPoint(TimeLineIDtli,List*history,
4242
TimeLineID*nextTLI);

‎src/include/executor/executor.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,7 @@ ExecEvalExprSwitchContext(ExprState *state,
314314
* ExecProject
315315
*
316316
* Projects a tuple based on projection info and stores it in the slot passed
317-
* toExecBuildProjectInfo().
317+
* toExecBuildProjectionInfo().
318318
*
319319
* Note: the result is always a virtual tuple; therefore it may reference
320320
* the contents of the exprContext's scan tuples and/or temporary results

‎src/include/executor/tablefunc.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@ struct TableFuncScanState;
2020
* TableFuncRoutine holds function pointers used for generating content of
2121
* table-producer functions, such as XMLTABLE.
2222
*
23-
*InitBuilder initialize table builder private objects. The output tuple
23+
*InitOpaque initializes table builder private objects. The output tuple
2424
* descriptor, input functions for the columns, and typioparams are passed
2525
* from executor state.
2626
*
27-
*SetDoc is called to define the input document. The table builder may
27+
*SetDocument is called to define the input document. The table builder may
2828
* apply additional transformations not exposed outside the table builder
2929
* context.
3030
*
@@ -45,7 +45,7 @@ struct TableFuncScanState;
4545
* builder context such that each subsequent GetValue call returns the values
4646
* for the indicated column for the row being processed.
4747
*
48-
*DestroyBuilder shall release all resources associated with a table builder
48+
*DestroyOpaque shall release all resources associated with a table builder
4949
* context. It may be called either because all rows have been consumed, or
5050
* because an error occurred while processing the table expression.
5151
*/

‎src/include/nodes/execnodes.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -593,7 +593,7 @@ typedef struct EState
593593
* and with which options. es_jit is created on-demand when JITing is
594594
* performed.
595595
*
596-
*es_jit_combined_instr is the combined, on demand allocated,
596+
*es_jit_worker_instr is the combined, on demand allocated,
597597
* instrumentation from all workers. The leader's instrumentation is kept
598598
* separate, and is combined on demand by ExplainPrintJITSummary().
599599
*/

‎src/include/partitioning/partprune.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,10 @@ typedef struct PartitionPruneContext
6060
}PartitionPruneContext;
6161

6262
/*
63-
* PruneCxtStateIdx() computes the correct index into the stepcmpfuncs[],
64-
*exprstates[]andexprhasexecparam[] arrays for step step_id and
65-
*partition key column keyno.(Note: there is code that assumes the
66-
*entries for a given step aresequential, so this is not chosen freely.)
63+
* PruneCxtStateIdx() computes the correct index into the stepcmpfuncs[]
64+
* andexprstates[] arrays for step step_id and partition key column keyno.
65+
* (Note: there is code that assumes the entries for a given step are
66+
* sequential, so this is not chosen freely.)
6767
*/
6868
#definePruneCxtStateIdx(partnatts,step_id,keyno) \
6969
((partnatts) * (step_id) + (keyno))

‎src/include/port/atomics/generic-acc.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ pg_atomic_compare_exchange_u32_impl(volatile pg_atomic_uint32 *ptr,
6868
_Asm_mf();
6969
/*
7070
* Notes:
71-
*DOWN_MEM_FENCE | _UP_MEM_FENCE prevents reordering by the compiler
71+
*_DOWN_MEM_FENCE | _UP_MEM_FENCE prevents reordering by the compiler
7272
*/
7373
current=_Asm_cmpxchg(_SZ_W,/* word */
7474
_SEM_REL,

‎src/interfaces/ecpg/compatlib/exports.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# src/interfaces/ecpg/compatlib/exports.txt
2-
# Functions to be exported byecpg_compatlib DLL
2+
# Functions to be exported bylibecpg_compat DLL
33
ECPG_informix_get_var 1
44
ECPG_informix_set_var 2
55
decadd 3

‎src/interfaces/ecpg/ecpglib/ecpglib_extern.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -195,11 +195,8 @@ char *ecpg_strdup(const char *, int);
195195
constchar*ecpg_type_name(enumECPGttype);
196196
intecpg_dynamic_type(Oid);
197197
intsqlda_dynamic_type(Oid,enumCOMPAT_MODE);
198-
voidecpg_free_auto_mem(void);
199198
voidecpg_clear_auto_mem(void);
200199

201-
structdescriptor*ecpggetdescp(int,char*);
202-
203200
structdescriptor*ecpg_find_desc(intline,constchar*name);
204201

205202
structprepared_statement*ecpg_find_prepared_statement(constchar*,

‎src/interfaces/ecpg/ecpglib/execute.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1899,7 +1899,7 @@ ecpg_process_output(struct statement *stmt, bool clear_result)
18991899

19001900
/*
19011901
* execution should never reach this code because it is already
1902-
* handled inECPGcheck_PQresult()
1902+
* handled inecpg_check_PQresult()
19031903
*/
19041904
ecpg_log("ecpg_process_output on line %d: unknown execution status type\n",
19051905
stmt->lineno);

‎src/interfaces/ecpg/include/ecpglib.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,6 @@ char *ECPGprepared_statement(const char *, const char *, int);
6363
PGconn*ECPGget_PGconn(constchar*);
6464
PGTransactionStatusTypeECPGtransactionStatus(constchar*);
6565

66-
char*ECPGerrmsg(void);
67-
6866
/* print an error message */
6967
voidsqlprint(void);
7068

‎src/interfaces/ecpg/preproc/Makefile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ override CPPFLAGS := -I../include -I$(top_srcdir)/src/interfaces/ecpg/include \
1919
-I. -I$(srcdir)\
2020
-I$(top_srcdir)/src/interfaces/ecpg/ecpglib\
2121
-I$(libpq_srcdir)\
22-
-DECPG_COMPILE\
2322
$(CPPFLAGS)
2423

2524
overrideCFLAGS +=$(PTHREAD_CFLAGS)

‎src/interfaces/ecpg/preproc/preproc_extern.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ extern intbraces_open,
3030
struct_level,
3131
ecpg_internal_var;
3232
externchar*current_function;
33-
externchar*descriptor_index;
3433
externchar*descriptor_name;
3534
externchar*connection;
3635
externchar*input_filename;

‎src/pl/plpgsql/src/pl_exec.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3294,10 +3294,10 @@ exec_stmt_return_next(PLpgSQL_execstate *estate,
32943294
* reference; in particular, this path is always taken in functions with
32953295
* one or more OUT parameters.
32963296
*
3297-
* Unlikeexec_statement_return, there's no special win here for R/W
3298-
*expandedvalues, since they'll have to get flattened to go into the
3299-
*tuplestore.Indeed, we'd better make them R/O to avoid any risk of the
3300-
*casting stepchanging them in-place.
3297+
* Unlikeexec_stmt_return, there's no special win here for R/W expanded
3298+
* values, since they'll have to get flattened to go into the tuplestore.
3299+
* Indeed, we'd better make them R/O to avoid any risk of the casting step
3300+
* changing them in-place.
33013301
*/
33023302
if (stmt->retvarno >=0)
33033303
{

‎src/test/regress/regressplans.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ mv -f regression.out planregress/out.in
7272
mv -f regression.diffs planregress/diffs.in
7373
PGOPTIONS="$PGOPTIONS -fi -fn -fh"$MAKE runtest
7474
mv -f regression.out planregress/out.inh
75-
mv -f regression.diffsregression.planregress/inh
75+
mv -f regression.diffsplanregress/diffs.inh
7676
PGOPTIONS="$PGOPTIONS -fi -fn -fm"$MAKE runtest
7777
mv -f regression.out planregress/out.inm
7878
mv -f regression.diffs planregress/diffs.inm

‎src/tools/msvc/Mkvcbuild.pm

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,6 @@ sub mkvcbuild
309309
$ecpg->AddIncludeDir('src/interfaces/libpq');
310310
$ecpg->AddPrefixInclude('src/interfaces/ecpg/preproc');
311311
$ecpg->AddFiles('src/interfaces/ecpg/preproc','pgc.l','preproc.y');
312-
$ecpg->AddDefine('ECPG_COMPILE');
313312
$ecpg->AddReference($libpgcommon,$libpgport);
314313

315314
my$pgregress_ecpg =

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp