NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit6b67d72

Amit Kapila

committed

Fix race condition in drop subscription's handling of tablesync slots.

Commitce0fdbf made tablesync slots permanent and allow DropSubscription to drop such slots. However, it is possible that beforetablesync worker could get the acknowledgment of slot creation, dropsubscription stops it and that can lead to a dangling slot on thepublisher. Prevent cancel/die interrupts while creating a slot in thetablesync worker.Reported-by: Thomas Munro as per buildfarmAuthor: Amit KapilaReviewed-by: Vignesh C, Takamichi OsumiDiscussion:https://postgr.es/m/CA+hUKGJG9dWpw1cOQ2nzWU8PHjm=PTraB+KgE5648K9nTfwvxg@mail.gmail.com

1 parent7efeb21 commit6b67d72Copy full SHA for 6b67d72

File tree

1 file changed

-0

lines changed

src/backend/replication/logical
- tablesync.c

1 file changed

-0

lines changed

`‎src/backend/replication/logical/tablesync.c`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1051,9 +1051,16 @@ LogicalRepSyncTableStart(XLogRecPtr *origin_startpos)`
`1051`	`1051`	`* Create a new permanent logical decoding slot. This slot will be used`
`1052`	`1052`	`* for the catchup phase after COPY is done, so tell it to use the`
`1053`	`1053`	`* snapshot to make the final data consistent.`
	`1054`	`+ *`
	`1055`	`+ * Prevent cancel/die interrupts while creating slot here because it is`
	`1056`	`+ * possible that before the server finishes this command, a concurrent`
	`1057`	`+ * drop subscription happens which would complete without removing this`
	`1058`	`+ * slot leading to a dangling slot on the server.`
`1054`	`1059`	`*/`
	`1060`	`+HOLD_INTERRUPTS();`
`1055`	`1061`	`walrcv_create_slot(wrconn,slotname, false/* permanent */ ,`
`1056`	`1062`	`CRS_USE_SNAPSHOT,origin_startpos);`
	`1063`	`+RESUME_INTERRUPTS();`
`1057`	`1064`
`1058`	`1065`	`/*`
`1059`	`1066`	`* Setup replication origin tracking. The purpose of doing this before the`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6b67d72

File tree

1 file changed

1 file changed

`‎src/backend/replication/logical/tablesync.c`

0 commit comments