Commit6b65a7f

committed

Remove TupleDesc remapping logic from tqueue.c.

With the introduction of a shared memory record typmod registry, it is nolonger necessary to remap record typmods when sending tuples between backendsso most of tqueue.c can be removed.Author: Thomas MunroReviewed-By: Andres FreundDiscussion:https://postgr.es/m/CAEepm=0ZtQ-SpsgCyzzYpsXS6e=kZWqk3g5Ygn3MDV7A8dabUA@mail.gmail.com

1 parentcc5f813 commit6b65a7fCopy full SHA for 6b65a7f

File tree

+27

-1110

lines changed

+27

-1110

lines changed

Lines changed: 2 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -608,14 +608,12 @@ ExecInitParallelPlan(PlanState planstate, EState estate, int nworkers,`
`608`	`608`
`609`	`609`	`/*`
`610`	`610`	`* Set up tuple queue readers to read the results of a parallel subplan.`
`611`		`- * All the workers are expected to return tuples matching tupDesc.`
`612`	`611`	`*`
`613`	`612`	`* This is separate from ExecInitParallelPlan() because we can launch the`
`614`	`613`	`* worker processes and let them start doing something before we do this.`
`615`	`614`	`*/`
`616`	`615`	`void`
`617`		`-ExecParallelCreateReaders(ParallelExecutorInfo*pei,`
`618`		`-TupleDesctupDesc)`
	`616`	`+ExecParallelCreateReaders(ParallelExecutorInfo*pei)`
`619`	`617`	`{`
`620`	`618`	`intnworkers=pei->pcxt->nworkers_launched;`
`621`	`619`	`inti;`
`@@ -631,8 +629,7 @@ ExecParallelCreateReaders(ParallelExecutorInfo *pei,`
`631`	`629`	`{`
`632`	`630`	`shm_mq_set_handle(pei->tqueue[i],`
`633`	`631`	`pei->pcxt->worker[i].bgwhandle);`
`634`		`-pei->reader[i]=CreateTupleQueueReader(pei->tqueue[i],`
`635`		`-tupDesc);`
	`632`	`+pei->reader[i]=CreateTupleQueueReader(pei->tqueue[i]);`
`636`	`633`	`}`
`637`	`634`	`}`
`638`	`635`	`}`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -176,8 +176,7 @@ ExecGather(PlanState *pstate)`
`176`	`176`	`/* Set up tuple queue readers to read the results. */`
`177`	`177`	`if (pcxt->nworkers_launched>0)`
`178`	`178`	`{`
`179`		`-ExecParallelCreateReaders(node->pei,`
`180`		`-fslot->tts_tupleDescriptor);`
	`179`	`+ExecParallelCreateReaders(node->pei);`
`181`	`180`	`/* Make a working array showing the active readers */`
`182`	`181`	`node->nreaders=pcxt->nworkers_launched;`
`183`	`182`	`node->reader= (TupleQueueReader**)`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -217,7 +217,7 @@ ExecGatherMerge(PlanState *pstate)`
`217`	`217`	`/* Set up tuple queue readers to read the results. */`
`218`	`218`	`if (pcxt->nworkers_launched>0)`
`219`	`219`	`{`
`220`		`-ExecParallelCreateReaders(node->pei,node->tupDesc);`
	`220`	`+ExecParallelCreateReaders(node->pei);`
`221`	`221`	`/* Make a working array showing the active readers */`
`222`	`222`	`node->nreaders=pcxt->nworkers_launched;`
`223`	`223`	`node->reader= (TupleQueueReader**)`

Comments

(0)