NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit6b4a176

committed

Silence compiler warnings

In GetCachedPlan(), initialize 'plan' to silence a compiler warning, butalso add an Assert() to make sure we don't ever actually fall throughwith 'plan' still being set to NULL, since we are about to dereferenceit.Back-patch back to 9.2.Author: Stephen FrostDiscussion:https://postgr.es/m/20161129152102.GR13284%40tamriel.snowman.net

1 parent3f94796 commit6b4a176Copy full SHA for 6b4a176

File tree

1 file changed

-1

lines changed

src/backend/utils/cache
- plancache.c

1 file changed

-1

lines changed

`‎src/backend/utils/cache/plancache.c`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1093,7 +1093,7 @@ CachedPlan *`
`1093`	`1093`	`GetCachedPlan(CachedPlanSource*plansource,ParamListInfoboundParams,`
`1094`	`1094`	`booluseResOwner)`
`1095`	`1095`	`{`
`1096`		`-CachedPlan*plan;`
	`1096`	`+CachedPlan*plan=NULL;`
`1097`	`1097`	`List*qlist;`
`1098`	`1098`	`boolcustomplan;`
`1099`	`1099`
`@@ -1175,6 +1175,8 @@ GetCachedPlan(CachedPlanSource *plansource, ParamListInfo boundParams,`
`1175`	`1175`	`}`
`1176`	`1176`	`}`
`1177`	`1177`
	`1178`	`+Assert(plan!=NULL);`
	`1179`	`+`
`1178`	`1180`	`/* Flag the plan as in use by caller */`
`1179`	`1181`	`if (useResOwner)`
`1180`	`1182`	`ResourceOwnerEnlargePlanCacheRefs(CurrentResourceOwner);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6b4a176

File tree

1 file changed

1 file changed

`‎src/backend/utils/cache/plancache.c`

0 commit comments