NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit6a5bcf7

committed

postmaster: Reduce verbosity of environment dump debug message

Emitting each variable separately is unnecessarily verbose / hard to skimover. Emit the whole thing in one ereport() to address that.Also remove program name and function reference from the message. The formerdoesn't seem particularly helpful and the latter is provided by the elog.cinfrastructure these days.Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>Reviewed-by: Peter Eisentraut <peter@eisentraut.org>Discussion:https://postgr.es/m/leouteo5ozcrux3fepuhtbp6c56tbfd4naxeokidbx7m75cabz@hhw6g4urlowt

1 parent631db1d commit6a5bcf7Copy full SHA for 6a5bcf7

File tree

1 file changed

-9

lines changed

src/backend/postmaster
- postmaster.c

1 file changed

-9

lines changed

`‎src/backend/postmaster/postmaster.c`

Lines changed: 9 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -839,20 +839,20 @@ PostmasterMain(int argc, char *argv[])`
`839`	`839`	`#endif`
`840`	`840`
`841`	`841`	`/* For debugging: display postmaster environment */`
	`842`	`+if (message_level_is_interesting(DEBUG3))`
`842`	`843`	`{`
`843`	`844`	`externchar**environ;`
`844`	`845`	`char**p;`
	`846`	`+StringInfoDatasi;`
`845`	`847`
`846`		`-ereport(DEBUG3,`
`847`		`-(errmsg_internal("%s: PostmasterMain: initial environment dump:",`
`848`		`-progname)));`
`849`		`-ereport(DEBUG3,`
`850`		`-(errmsg_internal("-----------------------------------------")));`
	`848`	`+initStringInfo(&si);`
	`849`	`+`
	`850`	`+appendStringInfoString(&si,"initial environment dump:");`
`851`	`851`	`for (p=environ;*p;++p)`
`852`		`-ereport(DEBUG3,`
`853`		`-(errmsg_internal("\t%s",*p)));`
`854`		`-ereport(DEBUG3,`
`855`		`-(errmsg_internal("-----------------------------------------")));`
	`852`	`+appendStringInfo(&si,"\n%s",*p);`
	`853`	`+`
	`854`	`+ereport(DEBUG3,errmsg_internal("%s",si.data));`
	`855`	`+pfree(si.data);`
`856`	`856`	`}`
`857`	`857`
`858`	`858`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6a5bcf7

File tree

1 file changed

1 file changed

`‎src/backend/postmaster/postmaster.c`

0 commit comments