Commit6a1f082

committed

Improve regression test coverage of GiST index building.

Add a test case that exercises the "buffering build" code path.This covers almost all the non-error-case lines in gistbuild.cand gistbuildbuffers.c.Matheus Alcantara, based on earlier work by Pavel BorisovDiscussion:https://postgr.es/m/3z8Fde-IHbW57a7bEZtaf19f4YOCWu67IZoWJoGW18rKD9R16ZHHchf4d7KFI3Yg7-0N4NonFuwKEgh98HjMCZYoVx7KOioPo6Wn2nZRpf4=@pm.me

1 parentbe39d88 commit6a1f082Copy full SHA for 6a1f082

File tree

-0

lines changed

-0

lines changed

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -387,6 +387,9 @@ select p from gist_tbl order by circle(p,1) <-> point(0,0) limit 1;`
`387`	`387`
`388`	`388`	`select p from gist_tbl order by circle(p,1) <-> point(0,0) limit 1;`
`389`	`389`	`ERROR: lossy distance functions are not supported in index-only scans`
	`390`	`+-- Force an index build using buffering.`
	`391`	`+create index gist_tbl_box_index_forcing_buffering on gist_tbl using gist (p)`
	`392`	`+ with (buffering=on, fillfactor=50);`
`390`	`393`	`-- Clean up`
`391`	`394`	`reset enable_seqscan;`
`392`	`395`	`reset enable_bitmapscan;`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -169,6 +169,10 @@ explain (verbose, costs off)`
`169`	`169`	`select pfrom gist_tblorder bycircle(p,1)<->point(0,0)limit1;`
`170`	`170`	`select pfrom gist_tblorder bycircle(p,1)<->point(0,0)limit1;`
`171`	`171`
	`172`	`+-- Force an index build using buffering.`
	`173`	`+createindexgist_tbl_box_index_forcing_bufferingon gist_tbl using gist (p)`
	`174`	`+ with (buffering=on, fillfactor=50);`
	`175`	`+`
`172`	`176`	`-- Clean up`
`173`	`177`	`reset enable_seqscan;`
`174`	`178`	`reset enable_bitmapscan;`

Comments

(0)