forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit6a0779a
committed
Improve regression test case to avoid depending on system catalog stats.
In commit95f4e59 I added a regression test case that examinedthe plan of a query on system catalogs. That isn't a terribly great ideabecause the catalogs tend to change from version to version, or evenwithin a version if someone makes an unrelated regression-test change thatpopulates the catalogs a bit differently. Usually I try to make plannertest cases rely on test tables that have not changed since Berkeley days,but I got sloppy in this case because the submitted crasher example queriedthe catalogs and I didn't spend enough time on rewriting it. But it was aproblem waiting to happen, as I was rudely reminded when I tried to portthat patch into Salesforce's Postgres variant :-(. So spend a little moreeffort and rewrite the query to not use any system catalogs. I verifiedthat this version still provokes the Assert if95f4e59's code fixis reverted.I also removed the EXPLAIN output from the test, as it turns out that theassertion occurs while considering a plan that isn't the one ultimatelyselected anyway; so there's no value in risking any cross-platformvariation in that printout.Back-patch to 9.2, like the previous patch.1 parent94d626f commit6a0779a
2 files changed
+22
-64
lines changedLines changed: 13 additions & 43 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
2220 | 2220 |
| |
2221 | 2221 |
| |
2222 | 2222 |
| |
2223 |
| - | |
| 2223 | + | |
2224 | 2224 |
| |
2225 |
| - | |
2226 |
| - | |
2227 |
| - | |
| 2225 | + | |
2228 | 2226 |
| |
2229 |
| - | |
2230 |
| - | |
2231 |
| - | |
2232 |
| - | |
2233 |
| - | |
2234 |
| - | |
2235 |
| - | |
2236 |
| - | |
2237 |
| - | |
2238 |
| - | |
2239 |
| - | |
2240 |
| - | |
2241 |
| - | |
2242 |
| - | |
2243 |
| - | |
2244 |
| - | |
2245 |
| - | |
2246 |
| - | |
2247 |
| - | |
2248 |
| - | |
2249 |
| - | |
2250 |
| - | |
2251 |
| - | |
2252 |
| - | |
2253 |
| - | |
2254 |
| - | |
2255 |
| - | |
2256 |
| - | |
2257 |
| - | |
2258 |
| - | |
2259 |
| - | |
2260 |
| - | |
2261 |
| - | |
2262 |
| - | |
2263 |
| - | |
2264 |
| - | |
2265 |
| - | |
2266 |
| - | |
2267 |
| - | |
| 2227 | + | |
| 2228 | + | |
| 2229 | + | |
| 2230 | + | |
| 2231 | + | |
| 2232 | + | |
| 2233 | + | |
| 2234 | + | |
| 2235 | + | |
| 2236 | + | |
| 2237 | + | |
2268 | 2238 |
| |
2269 | 2239 |
| |
2270 | 2240 |
| |
|
Lines changed: 9 additions & 21 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
379 | 379 |
| |
380 | 380 |
| |
381 | 381 |
| |
382 |
| - | |
| 382 | + | |
383 | 383 |
| |
384 |
| - | |
385 |
| - | |
386 |
| - | |
387 |
| - | |
388 |
| - | |
389 |
| - | |
390 |
| - | |
391 |
| - | |
392 |
| - | |
393 |
| - | |
394 |
| - | |
395 |
| - | |
396 |
| - | |
| 384 | + | |
397 | 385 |
| |
398 |
| - | |
399 |
| - | |
400 |
| - | |
401 |
| - | |
402 |
| - | |
403 |
| - | |
404 |
| - | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
405 | 393 |
| |
406 | 394 |
| |
407 | 395 |
| |
|
0 commit comments
Comments
(0)