NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit697dd19

committed

Remove bogus assertion in transformExpressionList().

I think when I added this assertion (in commit8f889b1), I was onlythinking of the use of transformExpressionList at top level of INSERTand VALUES. But it's also called by transformRowExpr(), which cancertainly occur in an UPDATE targetlist, so it's inappropriate tosuppose that p_multiassign_exprs must be empty. Besides, since theinput is not expected to contain ResTargets, there's no reason itshould contain MultiAssignRefs either. Hence this code need notbe concerned about the state of p_multiassign_exprs, and we shouldjust drop the assertion.Per bug #17236 from ocean_li_996. It's been wrong for years,so back-patch to all supported branches.Discussion:https://postgr.es/m/17236-3210de9bcba1d7ca@postgresql.org

1 parent998d060 commit697dd19Copy full SHA for 697dd19

File tree

1 file changed

-4

lines changed

src/backend/parser
- parse_target.c

1 file changed

-4

lines changed

`‎src/backend/parser/parse_target.c`

Lines changed: 3 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -211,7 +211,9 @@ transformTargetList(ParseState pstate, List targetlist,`
`211`	`211`	`* This is the identical transformation to transformTargetList, except that`
`212`	`212`	`* the input list elements are bare expressions without ResTarget decoration,`
`213`	`213`	`* and the output elements are likewise just expressions without TargetEntry`
`214`		`- * decoration. We use this for ROW() and VALUES() constructs.`
	`214`	`+ * decoration. Also, we don't expect any multiassign constructs within the`
	`215`	`+ * list, so there's nothing to do for that. We use this for ROW() and`
	`216`	`+ * VALUES() constructs.`
`215`	`217`	`*`
`216`	`218`	`* exprKind is not enough to tell us whether to allow SetToDefault, so`
`217`	`219`	`* an additional flag is needed for that.`
`@@ -273,9 +275,6 @@ transformExpressionList(ParseState pstate, List exprlist,`
`273`	`275`	`result=lappend(result,e);`
`274`	`276`	`}`
`275`	`277`
`276`		`-/* Shouldn't have any multiassign items here */`
`277`		`-Assert(pstate->p_multiassign_exprs==NIL);`
`278`		`-`
`279`	`278`	`returnresult;`
`280`	`279`	`}`
`281`	`280`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit697dd19

File tree

1 file changed

1 file changed

`‎src/backend/parser/parse_target.c`

0 commit comments