Commit6974f57

authored and

committed

Push attidentity and attgenerated handling into BuildDescForRelation()

Previously, this was handled by the callers separately, but it can betrivially moved into BuildDescForRelation() so that it is handled in acentral place.Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org>Discussion:https://www.postgresql.org/message-id/flat/52a125e4-ff9a-95f5-9f61-b87cf447e4da@eisentraut.org

1 parent70efff3 commit6974f57Copy full SHA for 6974f57

File tree

-2

lines changed

-2

lines changed

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -856,6 +856,8 @@ BuildDescForRelation(const List *columns)`
`856`	`856`	`has_not_null \|=entry->is_not_null;`
`857`	`857`	`att->attislocal=entry->is_local;`
`858`	`858`	`att->attinhcount=entry->inhcount;`
	`859`	`+att->attidentity=entry->identity;`
	`860`	`+att->attgenerated=entry->generated;`
`859`	`861`	`}`
`860`	`862`
`861`	`863`	`if (has_not_null)`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -941,8 +941,6 @@ DefineRelation(CreateStmt *stmt, char relkind, Oid ownerId,`
`941`	`941`	`attr->atthasdef = true;`
`942`	`942`	`}`
`943`	`943`
`944`		`-attr->attidentity = colDef->identity;`
`945`		`-attr->attgenerated = colDef->generated;`
`946`	`944`	`attr->attcompression = GetAttributeCompression(attr->atttypid, colDef->compression);`
`947`	`945`	`if (colDef->storage_name)`
`948`	`946`	`attr->attstorage = GetAttributeStorage(attr->atttypid, colDef->storage_name);`

Comments

(0)