NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit6969dee

committed

Handle ReadFile() EOF correctly on Windows.

When ReadFile() encounters the end of a file while reading froma synchronous handle with an offset provided via OVERLAPPED, itreports an error instead of returning 0. By not handling that(undocumented) result correctly, we caused some noisy LOGmessages about an unknown error code. Repair.Back-patch to 12, where we started using pread()/ReadFile() withan offset.Reported-by: ZhenHua Cai, Amit KapilaDiagnosed-by: Juan Jose Santamaria FlechaTested-by: Amit KapilaDiscussion:https://postgr.es/m/CAA4eK1LK3%2BWRtpz68TiRdpHwxxWm%3D%2Bt1BMf-G68hhQsAQ41PZg%40mail.gmail.com

1 parent80e05a0 commit6969deeCopy full SHA for 6969dee

File tree

1 file changed

-0

lines changed

src/port
- pread.c

1 file changed

-0

lines changed

`‎src/port/pread.c`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,9 @@ pg_pread(int fd, void *buf, size_t size, off_t offset)`
`41`	`41`	`overlapped.Offset=offset;`
`42`	`42`	`if (!ReadFile(handle,buf,size,&result,&overlapped))`
`43`	`43`	`{`
	`44`	`+if (GetLastError()==ERROR_HANDLE_EOF)`
	`45`	`+return0;`
	`46`	`+`
`44`	`47`	`_dosmaperr(GetLastError());`
`45`	`48`	`return-1;`
`46`	`49`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6969dee

File tree

1 file changed

1 file changed

`‎src/port/pread.c`

0 commit comments