Commit68f7fe1

committed

Clarify docs on hot standby lock release

Andres Freund and Simon Riggs

1 parent8f40ad1 commit68f7fe1Copy full SHA for 68f7fe1

File tree

+11

-2

lines changed

+11

-2

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1564,6 +1564,11 @@ ProcArrayInstallImportedXmin(TransactionId xmin, TransactionId sourcexid)`
`1564`	`1564`	`* We don't worry about updating other counters, we want to keep this as`
`1565`	`1565`	`* simple as possible and leave GetSnapshotData() as the primary code for`
`1566`	`1566`	`* that bookkeeping.`
	`1567`	`+ *`
	`1568`	`+ * Note that if any transaction has overflowed its cached subtransactions`
	`1569`	`+ * then there is no real need include any subtransactions. That isn't a`
	`1570`	`+ * common enough case to worry about optimising the size of the WAL record,`
	`1571`	`+ * and we may wish to see that data for diagnostic purposes anyway.`
`1567`	`1572`	`*/`
`1568`	`1573`	`RunningTransactions`
`1569`	`1574`	`GetRunningTransactionData(void)`

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -540,6 +540,10 @@ StandbyTimeoutHandler(void)`
`540`	`540`	`* RelationLockList, so we can keep track of the various entries made by`
`541`	`541`	`* the Startup process's virtual xid in the shared lock table.`
`542`	`542`	`*`
	`543`	`+ * We record the lock against the top-level xid, rather than individual`
	`544`	`+ * subtransaction xids. This means AccessExclusiveLocks held by aborted`
	`545`	`+ * subtransactions are not released as early as possible on standbys.`
	`546`	`+ *`
`543`	`547`	`* List elements use type xl_rel_lock, since the WAL record type exactly`
`544`	`548`	`* matches the information that we need to keep track of.`
`545`	`549`	`*`
`@@ -673,8 +677,8 @@ StandbyReleaseAllLocks(void)`
`673`	`677`
`674`	`678`	`/*`
`675`	`679`	`* StandbyReleaseOldLocks`
`676`		`- *Release standby locks held by XIDs that aren't running, as long`
`677`		`- *as they're not prepared transactions.`
	`680`	`+ *Release standby locks held bytop-levelXIDs that aren't running,`
	`681`	`+ *aslong asthey're not prepared transactions.`
`678`	`682`	`*/`
`679`	`683`	`void`
`680`	`684`	`StandbyReleaseOldLocks(intnxids,TransactionId*xids)`

Comments

(0)