NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit68d704e

committed

Minimal fix for crash bug in quals_match_foreign_key.

Discussion is still underway as to whether to revert the entire patchthat added this function, but that discussion may not conclude beforebeta1. So, in the meantime, let's do at least this much.David Rowley

1 parentc7ea68f commit68d704eCopy full SHA for 68d704e

File tree

1 file changed

-4

lines changed

src/backend/optimizer/path
- costsize.c

1 file changed

-4

lines changed

`‎src/backend/optimizer/path/costsize.c`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -3944,13 +3944,13 @@ quals_match_foreign_key(PlannerInfo root, ForeignKeyOptInfo fkinfo,`
`3944`	`3944`	`if (i>0&&bms_is_member(quallstidx,qualmatches))`
`3945`	`3945`	`continue;`
`3946`	`3946`
`3947`		`-/*`
`3948`		`- * Here since 'usefulquals' only contains bitmap indexes for quals`
`3949`		`- * of type "var op var" we can safely skip checking this.`
`3950`		`- */`
`3951`	`3947`	`rinfo= (RestrictInfo*)lfirst(lc);`
`3952`	`3948`	`clause= (OpExpr*)rinfo->clause;`
`3953`	`3949`
	`3950`	`+/* only OpExprs are useful for consideration */`
	`3951`	`+if (!IsA(clause,OpExpr))`
	`3952`	`+continue;`
	`3953`	`+`
`3954`	`3954`	`/*`
`3955`	`3955`	`* If the operator does not match then there's little point in`
`3956`	`3956`	`* checking the operands.`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit68d704e

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/path/costsize.c`

0 commit comments