Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit67915fb

Browse files
committed
Fix use-after-free bug when renaming constraints
This is an oversight from recent commitb13fd34. While on it, tweakthe previous test with a better name for the renamed primary key.Detected by buildfarm member prion which forces relation cache releasewith -DRELCACHE_FORCE_RELEASE. Back-patch down to 9.4 as the previouscommit.
1 parentb13fd34 commit67915fb

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

‎src/backend/commands/tablecmds.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3020,12 +3020,12 @@ rename_constraint_internal(Oid myrelid,
30203020

30213021
if (targetrelation)
30223022
{
3023-
relation_close(targetrelation,NoLock);/* close rel but keep lock */
3024-
30253023
/*
30263024
* Invalidate relcache so as others can see the new constraint name.
30273025
*/
30283026
CacheInvalidateRelcache(targetrelation);
3027+
3028+
relation_close(targetrelation,NoLock);/* close rel but keep lock */
30293029
}
30303030

30313031
returnaddress;

‎src/test/regress/expected/alter_table.out

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,7 @@ CREATE TABLE constraint_rename_cache (a int,
400400
ALTER TABLE constraint_rename_cache
401401
RENAME CONSTRAINT chk_a TO chk_a_new;
402402
ALTER TABLE constraint_rename_cache
403-
RENAME CONSTRAINT constraint_rename_cache_pkey TOchk_a_gt_zero;
403+
RENAME CONSTRAINT constraint_rename_cache_pkey TOconstraint_rename_pkey_new;
404404
CREATE TABLE like_constraint_rename_cache
405405
(LIKE constraint_rename_cache INCLUDING ALL);
406406
\d like_constraint_rename_cache

‎src/test/regress/sql/alter_table.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ CREATE TABLE constraint_rename_cache (a int,
296296
ALTERTABLE constraint_rename_cache
297297
RENAMECONSTRAINT chk_a TO chk_a_new;
298298
ALTERTABLE constraint_rename_cache
299-
RENAMECONSTRAINT constraint_rename_cache_pkey TOchk_a_gt_zero;
299+
RENAMECONSTRAINT constraint_rename_cache_pkey TOconstraint_rename_pkey_new;
300300
CREATETABLElike_constraint_rename_cache
301301
(LIKE constraint_rename_cache INCLUDING ALL);
302302
\d like_constraint_rename_cache

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp