NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit675cd76

committed

Report any XLogReadRecord() error in XlogReadTwoPhaseData().

Buildfarm members kittiwake and tadarida have witnessed errors at thissite. The site discarded key facts. Back-patch to v10 (all supportedversions).Reviewed by Michael Paquier and Tom Lane.Discussion:https://postgr.es/m/20211107013157.GB790288@rfd.leadboat.com

1 parent9aa91cb commit675cd76Copy full SHA for 675cd76

File tree

1 file changed

+12

-4

lines changed

src/backend/access/transam
- twophase.c

1 file changed

+12

-4

lines changed

`‎src/backend/access/transam/twophase.c`

Lines changed: 12 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1409,10 +1409,18 @@ XlogReadTwoPhaseData(XLogRecPtr lsn, char *buf, int len)`
`1409`	`1409`	`ThisTimeLineID=save_currtli;`
`1410`	`1410`
`1411`	`1411`	`if (record==NULL)`
`1412`		`-ereport(ERROR,`
`1413`		`-(errcode_for_file_access(),`
`1414`		`-errmsg("could not read two-phase state from WAL at %X/%X",`
`1415`		`-LSN_FORMAT_ARGS(lsn))));`
	`1412`	`+{`
	`1413`	`+if (errormsg)`
	`1414`	`+ereport(ERROR,`
	`1415`	`+(errcode_for_file_access(),`
	`1416`	`+errmsg("could not read two-phase state from WAL at %X/%X: %s",`
	`1417`	`+LSN_FORMAT_ARGS(lsn),errormsg)));`
	`1418`	`+else`
	`1419`	`+ereport(ERROR,`
	`1420`	`+(errcode_for_file_access(),`
	`1421`	`+errmsg("could not read two-phase state from WAL at %X/%X",`
	`1422`	`+LSN_FORMAT_ARGS(lsn))));`
	`1423`	`+}`
`1416`	`1424`
`1417`	`1425`	`if (XLogRecGetRmid(xlogreader)!=RM_XACT_ID\|\|`
`1418`	`1426`	`(XLogRecGetInfo(xlogreader)&XLOG_XACT_OPMASK)!=XLOG_XACT_PREPARE)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit675cd76

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/twophase.c`

0 commit comments