NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit67445de

committed

Add missing exit() in pg_verifybackup when failing to find pg_waldump

pg_verifybackup needs by default pg_waldump to check after a range ofWAL segments required for a backup, except if --no-parse-wal isspecified. The code checked for the presence of the binary pg_waldumpin an installation and reported an error, but it forgot to properlyexit(). This could lead to confusing errors reported.Reviewed-by: Robert Haas, Fabien CoelhoDiscussion:https://postgr.es/m/YQDMdB+B68yePFeT@paquier.xyzBackpatch-through: 13

1 parentf2a3d74 commit67445deCopy full SHA for 67445de

File tree

1 file changed

-0

lines changed

src/bin/pg_verifybackup
- pg_verifybackup.c

1 file changed

-0

lines changed

`‎src/bin/pg_verifybackup/pg_verifybackup.c‎`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -304,6 +304,7 @@ main(int argc, char **argv)`
`304`	`304`	`"but was not the same version as %s.\n"`
`305`	`305`	`"Check your installation.",`
`306`	`306`	`"pg_waldump",full_path,"pg_verifybackup");`
	`307`	`+exit(1);`
`307`	`308`	`}`
`308`	`309`	`}`
`309`	`310`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit67445de

File tree

1 file changed

1 file changed

`‎src/bin/pg_verifybackup/pg_verifybackup.c‎`

0 commit comments