Commit66e9ee7

committed

Print error on SELECT tab FROM tab:

You can't use relation names alone in the target list, try relation.*

1 parent984bf07 commit66e9ee7Copy full SHA for 66e9ee7

File tree

+11

-6

lines changed

+11

-6

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`TODO list for PostgreSQL`
`2`	`2`	`========================`
`3`		`-Last updated:Mon May 21 14:36:45 EDT 2001`
	`3`	`+Last updated:Mon May 21 14:40:08 EDT 2001`
`4`	`4`
`5`	`5`	`Current maintainer:Bruce Momjian (pgman@candle.pha.pa.us)`
`6`	`6`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/parser/parse_expr.c,v 1.95 2001/05/19 00:33:20 momjian Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/parser/parse_expr.c,v 1.96 2001/05/21 18:42:08 momjian Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -585,7 +585,10 @@ transformIdent(ParseState pstate, Ident ident, int precedence)`
`585`	`585`	`Node*var=colnameToVar(pstate,ident->name);`
`586`	`586`
`587`	`587`	`if (var!=NULL)`
	`588`	`+{`
	`589`	`+ident->isRel= FALSE;`
`588`	`590`	`result=transformIndirection(pstate,var,ident->indirection);`
	`591`	`+}`
`589`	`592`	`}`
`590`	`593`
`591`	`594`	`if (result==NULL)`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/parser/parse_target.c,v 1.66 2001/03/22 03:59:41 momjian Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/parser/parse_target.c,v 1.67 2001/05/21 18:42:08 momjian Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -55,6 +55,9 @@ transformTargetEntry(ParseState *pstate,`
`55`	`55`	`if (expr==NULL)`
`56`	`56`	`expr=transformExpr(pstate,node,EXPR_COLUMN_FIRST);`
`57`	`57`
	`58`	`+if (IsA(expr,Ident)&& ((Ident*)expr)->isRel)`
	`59`	`+elog(ERROR,"You can't use relation names alone in the target list, try relation.*.");`
	`60`	`+`
`58`	`61`	`type_id=exprType(expr);`
`59`	`62`	`type_mod=exprTypmod(expr);`
`60`	`63`

Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`* Portions Copyright (c) 1996-2001, PostgreSQL Global Development Group`
`8`	`8`	`* Portions Copyright (c) 1994, Regents of the University of California`
`9`	`9`	`*`
`10`		`- * $Id: parsenodes.h,v 1.128 2001/05/20 20:28:20 tgl Exp $`
	`10`	`+ * $Id: parsenodes.h,v 1.129 2001/05/21 18:42:08 momjian Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -1081,8 +1081,7 @@ typedef struct Ident`
`1081`	`1081`	`NodeTagtype;`
`1082`	`1082`	`charname;/ its name */`
`1083`	`1083`	`Listindirection;/ array references */`
`1084`		`-boolisRel;/* is a relation - filled in by`
`1085`		`- * transformExpr() */`
	`1084`	`+boolisRel;/* is this a relation or a column? */`
`1086`	`1085`	`}Ident;`
`1087`	`1086`
`1088`	`1087`	`/*`

Comments

(0)