NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit66a8f09

committed

change wire protocol data type for history file content

This was marked as BYTEA, but is more like TEXT, which is how we alreadypass the history timeline file name. Internally, we don't do anyencoding or bytea escape handling, but TEXT seems closest. This shouldcause no behavioral change.Reported-by: Brar PieningDiscussion:https://postgr.es/m/6a1b9cd9-17e3-df67-be55-86102af6bdf5@gmx.deBackpatch-through: master

1 parent951dfa3 commit66a8f09Copy full SHA for 66a8f09

File tree

2 files changed

-3

lines changed

doc/src/sgml
- protocol.sgml
src/backend/replication
- walsender.c

2 files changed

-3

lines changed

`‎doc/src/sgml/protocol.sgml‎`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1859,7 +1859,9 @@ The commands accepted in replication mode are:`
`1859`	`1859`	`<para>`
`1860`	`1860`	`Requests the server to send over the timeline history file for timeline`
`1861`	`1861`	`<replaceable class="parameter">tli</replaceable>. Server replies with a`
`1862`		`- result set of a single row, containing two fields:`
	`1862`	`+ result set of a single row, containing two fields. While the fields`
	`1863`	`+ are labeled as <type>text</type>, they effectively return raw bytes,`
	`1864`	`+ with no encoding conversion:`
`1863`	`1865`	`</para>`
`1864`	`1866`
`1865`	`1867`	`<para>`
`@@ -1877,7 +1879,7 @@ The commands accepted in replication mode are:`
`1877`	`1879`
`1878`	`1880`	`<varlistentry>`
`1879`	`1881`	`<term>`
`1880`		`- <literal>content</literal> (<type>bytea</type>)`
	`1882`	`+ <literal>content</literal> (<type>text</type>)`
`1881`	`1883`	`</term>`
`1882`	`1884`	`<listitem>`
`1883`	`1885`	`<para>`

`‎src/backend/replication/walsender.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -496,7 +496,7 @@ SendTimeLineHistory(TimeLineHistoryCmd *cmd)`
`496`	`496`	`pq_sendstring(&buf,"content");/* col name */`
`497`	`497`	`pq_sendint32(&buf,0);/* table oid */`
`498`	`498`	`pq_sendint16(&buf,0);/* attnum */`
`499`		`-pq_sendint32(&buf,BYTEAOID);/* type oid */`
	`499`	`+pq_sendint32(&buf,TEXTOID);/* type oid */`
`500`	`500`	`pq_sendint16(&buf,-1);/* typlen */`
`501`	`501`	`pq_sendint32(&buf,0);/* typmod */`
`502`	`502`	`pq_sendint16(&buf,0);/* format code */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit66a8f09

File tree

2 files changed

2 files changed

`‎doc/src/sgml/protocol.sgml‎`

`‎src/backend/replication/walsender.c‎`

0 commit comments